Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role + Description fields in People collection #204

Open
pr130 opened this issue May 3, 2023 · 5 comments
Open

Role + Description fields in People collection #204

pr130 opened this issue May 3, 2023 · 5 comments
Labels

Comments

@pr130
Copy link
Contributor

pr130 commented May 3, 2023

could we have a general description and role field in the People collection? then we could reuse this in different collections that inherit from the People collection instead of copy-pasting the description to different components/collections.
e.g. when I insert a Contact in the page builder and I don't see the need to write a dedicated text, i have to copy paste from the global admin.

maybe it could be so that the Title & description in this case could be optional and then:

  • if empty: use text/role from People collection
  • if not empty: use provided text

or is this too confusing? 😬

@pr130 pr130 added enhancement New feature or request backlog Directus labels May 3, 2023
@pr130 pr130 changed the title Contacts component: Use text from Person if description is empty Role + Description fields in People collection May 3, 2023
@KonradUdoHannes
Copy link
Collaborator

I can't say I fully understand the directus schema yet, but from how I understand it we have the following situation.
We have People and then Global Administrators, Local Administrators and contacts all can include the people. Currently Description and Position are fields that are separately added to Global Administrators , Local Administrators and contacts, leading to the issue (+maintenance issues if the description ever changes).

Maybe we can move the Description field to People such that the other data models automatically have it associates. Maybe we can also do this for Position possibly renaming it to Positions to track potentially both global and local admin positions.

@jstet Do you think its feasible? Schema changes are of course always painful, but the further I get with error handling and logging the less painful it will get (yet we won't reach painless 😅). If its not feasible we can brainstorm more about client side solutions.

@jstet
Copy link
Member

jstet commented May 4, 2023

@frie and I talked about this yesterday in a call. I did not add description and position to people, because people can have different positions and descriptions in different contexts, e.g. as a part of the remote office vs lc head vs content creator.

We agreed to postbone this for now and see how much of an issue this is in writing content in the cms

@pr130
Copy link
Contributor Author

pr130 commented May 4, 2023

yes for postponing it after the launch. just to note: also came up with Content Creators today (description wise)

@pr130
Copy link
Contributor Author

pr130 commented Aug 7, 2023

note from #555

in my opinion the use case is not worth the complexity and added effort of maintaining them in different places.
imo there's no harm in using general descriptions that cover all that the person does within CorrelAid. For example, if Marco shows up on LC Konstanz, it's also ok to write that he's part of the board and vice versa. I'd actually argue that it's a plus because it shows that people can be involved in different roles at once.

For blog posts, temporal stability is actually more of a problem (aka: Johannes 8 years ago has the same description as content creator Johannes today) but again, for me, i'd keep it as simple as possible.

If you think this has implications too far for a PR. i can move my comment to the related issue and revert the changes (i guess i am just frustrated that i manually added things in the wrong place in directus)

@pr130 pr130 mentioned this issue Aug 7, 2023
4 tasks
@jstet
Copy link
Member

jstet commented Jan 16, 2024

As I have just updated the board i had to think about this again. Personally I still think it makes sense to have
the Role + Description in different collections. I don't mind that much to completely move the description to the Person collection. We cant move the role however because people have different roles. Currently we additionally have description and role in the person collection, which is a bit confusing.

Any new thoughts @friep or @KonradUdoHannes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants