Fix bug introduced by 443a2fd #2351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 443a2fd addedsome extra checks for convergence in the Helmholtz PHSU flash routines. However, its checking was more aggressive than the original routine. This caused the routine to raise an exception on several values that had previously been deemed acceptable. This trickled down to cause the TTSE tables to be filled with empty values, making them less robust. This commit allows for a solution to be acceptable if the change is small between iterations as was originally intended.
|
Thank you very much - I can review it next week! |
|
@jowr - Have you had a chance to review the PR yet? |
|
I think this seems reasonable. Shall I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Commit 443a2fd added some extra checks for convergence in the Helmholtz PHSU flash routines. However, its checking was more aggressive than the original routine. This caused the routine to raise an exception on several values that had previously been deemed acceptable. This trickled down to cause the TTSE tables to be filled with empty values, making them less robust.
This commit allows for a solution to be acceptable if the change is small between iterations as was originally intended.
Benefits
The docs now build properly.
Possible Drawbacks
None known. However we should ensure that the tests pass acceptably.
Verification Process
I manually ran
Web/scripts/coolprop.tabular.speed.pywith the updated code and with the current master branch. Using master causes a crash - this was what was causing the docs the fail to build in the github pipeline. Running with this new commit causescoolprop.tabular.speed.pyto run to completion.Applicable Issues
Closes #2349