Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INCOMP::AEG[0.5] is different from the ASHRAE HANDBOOK 2021 SI #2336

Open
birdol opened this issue Dec 14, 2023 · 8 comments
Open

INCOMP::AEG[0.5] is different from the ASHRAE HANDBOOK 2021 SI #2336

birdol opened this issue Dec 14, 2023 · 8 comments

Comments

@birdol
Copy link

birdol commented Dec 14, 2023

Cooprop Ver 6.6
Windows 11 ,Excel 2016

I compared the differences in the calculations ,As shown in the figure

error

Is this normal? Or am I doing something wrong?

@ibell
Copy link
Contributor

ibell commented Dec 15, 2023

That is normal - the models are not identical. Did you look into which data are used in CoolProp and the handbook?

@birdol
Copy link
Author

birdol commented Dec 15, 2023

emm....I don't know how to determine what data coolprop uses

@ibell
Copy link
Contributor

ibell commented Dec 15, 2023

@jowr do you have any idea? Is it because the precise model used in the handbook is not used, rather the model is fit to the tabulated data?

@jowr
Copy link
Member

jowr commented Feb 12, 2024

The data we use is here: https://github.com/CoolProp/CoolProp/blob/master/dev/incompressible_liquids/CPIncomp/data/SecCool/xVolume/ASHRAE%2C%20Ethylene%20Glycol_Cond.txt

Are you sure you are comparing the correct fractions? Are you actually using volume fractions?

@jowr
Copy link
Member

jowr commented Feb 12, 2024

Furthermore, we used the ASHRAE Handbook 2001 - maybe the data changed in the meantime?

@birdol
Copy link
Author

birdol commented May 6, 2024

Furthermore, we used the ASHRAE Handbook 2001 - maybe the data changed in the meantime?

According to my current verification, you are correct. The content in the ASHRAE Handbook is the same in the 2017 and 2022 2021 versions, but it seems there are differences in the 2001 version, possibly due to some errors. Please refer to the image for more details.

asharehandbook_2001_Cond_EthyleneGlycol
asharehandbook_2017_Cond_EthyleneGlycol
asharehandbook_2021_Cond_EthyleneGlycol

@ibell
Copy link
Contributor

ibell commented May 7, 2024

Probably the models used to generate the tabular data have been updated, which is why the numbers are different. Is it stated what models were used?

@birdol
Copy link
Author

birdol commented May 8, 2024

In the 2021 version of the handbook, only the data source is indicated as Source: Dow Chemical 2001b. No detailed information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants