Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent params for timecorr #93

Open
lucywowen opened this issue Dec 6, 2018 · 2 comments
Open

consistent params for timecorr #93

lucywowen opened this issue Dec 6, 2018 · 2 comments
Assignees

Comments

@lucywowen
Copy link
Collaborator

For some parameters (rfun) you pass a string, but for other paramters (cfun, combine, weights_fun, etc.) you pass a function. Should we discuss this?

@jeremymanning
Copy link
Member

hmm...yes, we should probably discuss this...

ideally we could support either strings or functions for each thing. one approach might be to have a dictionary whose keys are the string names of functions and whose values are functions. then if the user passes a string, we could convert it to the associated function by looking up that key's value in the dictionary.

proposed plan:

  1. i'm happy to discuss; let me know if/when you'd like to do that
  2. i'm ok with proceeding with the current API if it's functional, and then keeping this issue open to deal with in a future release

@lucywowen lucywowen modified the milestones: v0.1, future releas, future release Dec 11, 2018
@lucywowen lucywowen self-assigned this Dec 11, 2018
@jeremymanning
Copy link
Member

status of this? should we deal with this in a future release? @lucywowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants