Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beacon api] check if we need to fix anything in our definitions #8223

Open
rolfyone opened this issue Apr 18, 2024 · 1 comment · May be fixed by #8338
Open

[beacon api] check if we need to fix anything in our definitions #8223

rolfyone opened this issue Apr 18, 2024 · 1 comment · May be fixed by #8338
Assignees
@gfukushima

Comments

@rolfyone
Copy link
Contributor

ethereum/beacon-APIs#444

I haven't read this closely, but if someone can take a look... its probably worth testing the query parameter.
@gfukushima gfukushima self-assigned this May 7, 2024
@gfukushima
Copy link
Contributor

Just double checking before executing on something that we don't want.
The PR mentioned above changes the type of the field skip_randao_verification.
In Teku we only have skip_randao_verification in the BlockV3. My understanding is that the type change is all we want to do in Teku.
We don't want to add this field to blinded_block, correct?
Same applies for BlockV2 which seems to be deprecated.

@gfukushima gfukushima linked a pull request May 27, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfukushima gfukushima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change skip_randao_verification param to string gfukushima/teku
2 participants
@rolfyone @gfukushima