Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message design #16

Open
bmcd opened this issue Nov 13, 2019 · 10 comments
Open

Improve error message design #16

bmcd opened this issue Nov 13, 2019 · 10 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bmcd
Copy link
Contributor

bmcd commented Nov 13, 2019

Right now the error appears at the top no matter which section threw the error and it pushes all the elements down.

Screen Shot 2019-11-13 at 12 00 45 PM

It would be nice to improve this, maybe localize the errors to the section/field that caused it and/or make it an overlay rather than an inline item.

@bmcd bmcd added the enhancement New feature or request label Nov 13, 2019
@bmcd bmcd added the good first issue Good for newcomers label Nov 13, 2019
@technicaldwiti
Copy link

Hi @bmcd87 ,
As i am a new comer to the opensource world and this is my first contribution can you please seggest me how to change the source code and able to see the changes ?
Now as per the readme file in the github ripo i have completed all the steps under the development section and I can connect the repo folder on my computer to the online remix-ide.
But i am not able to see the screen as shown in the picture.Can you please suggest me how to proceed?

Thank You.Looking foreword to hearing from you soon

@bmcd
Copy link
Contributor Author

bmcd commented Jun 15, 2020

First, have you used the plugin on the main remix site? http://remix.ethereum.org

If you haven't, I would go there, add the Quorum Network plugin, go to the Quorum tab, connect to your local quorum node, and deploy a contract.

Once you've done that and have seen how the flow is supposed to work, then go to http://remix-dev.goquorum.com and try doing the same thing (making sure you ran npm run start or yarn start to run the plugin code locally). The remix-dev version of remix looks for the quorum plugin code at localhost:3000.

Then if you have any issues, feel free to reply here with screenshots/error messages and we can figure out what's going wrong.

@technicaldwiti
Copy link

technicaldwiti commented Jun 15, 2020 via email

@bmcd
Copy link
Contributor Author

bmcd commented Jun 15, 2020

I think the reply didn't include the screenshot because it was through email. Can you try posting the screenshot directly in the github issue?

@technicaldwiti
Copy link

Thank you very much for the quick response.
Actually it seems that i had completed the above steps and then my screen
looks like the screenshot attached below

Did I setup the things correctly ?
Screenshot (654)_LI

@bmcd
Copy link
Contributor Author

bmcd commented Jun 15, 2020

Ah I see the confusion. That Geth RPC field should be the url to your Quorum node. Are you running a Quorum node on your local machine or using something like Kaleido or Chainstack to run a node?

@technicaldwiti
Copy link

First of all sorry for the delay.As this is weekend time , now i can work only for quorum-remix.

Q.Are you running a Quorum node on your local machine or using something like Kaleido or Chainstack to run a node?
Ans. I am running node on my local machine.
Should I use something else?

@bmcd
Copy link
Contributor Author

bmcd commented Jun 20, 2020

Sorry I don't mean 'node' as in NodeJS. I mean 'node' as in an instance of Quorum. It's unclear whether you are running an instance of Quorum or just running npm run start for quorum-remix, which does not start an instance of Quorum.

Quorum Remix is just a javascript frontend for interacting with a Quorum network through Remix. It doesn't really do anything if you don't have a Quorum network to connect to, so you need that running first.

  1. Let's ignore the remix plugin for now and just set up a Quorum network on your local machine. Go to Quorum Wizard and follow the instructions there. Quickstart will give you a 3 node network. Once you have that running, you can move on to remix.

  2. Go to http://remix.ethereum.org/, click on Solidity to load the solidity plugins, make sure the Quorum Network plugin is also enabled, go to the Quorum tab, and put http://localhost:22000 in the Geth RPC field and connect. localhost:22000 is where the first node in your Quorum network is running if you used the wizard. It should say Connected and the rest of the ui should show up.

  3. Click on the File Explorer tab and open the sample 1_Storage.sol contract. Then click on the Solidity Compiler tab and compile the contract. Now you can go back to the Quorum tab and you should be able to deploy the contract now. Click deploy, then the contract should show up in the deployed contracts list at the bottom. Expand the contract and try setting the storage value to 123 and then retrieving it.

  4. If you did all of the above, you've now seen how it's supposed to work in production. On Remix, our plugin's javascript is loaded from our production website. It's not easy to load a development version of the plugin using the official remix site. So we host a fork just for development that we run at http://remix-dev.goquorum.com/ Instead of loading the plugin from our production deployment, this site loads the plugin from localhost:3000.

  5. Now you can run npm run start in quorum-remix, go to the remix-dev site, and try to do the same stuff as in steps 2 and 3.

  6. Make a change to some react components and the ui should refresh automatically.

Here's a talk from a few months ago that gives a quick intro to what Quorum is and basically goes through steps 2-3 above: https://www.youtube.com/watch?v=lT5y4hQLwUQ

@technicaldwiti
Copy link

For quorum-wizard in windows the error comes as - 'grep' is not recognized as an internal or external command

@bmcd
Copy link
Contributor Author

bmcd commented Jun 20, 2020

Quorum doesn't work generally on Windows because it uses unix sockets heavily, which don't have full support (even in Windows Subsystem for Linux). Therefore the Wizard also doesn't support Windows right now. You can run it in a linux vm, or use Kaleido or Chainstack to set up a quorum network in the cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants