Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explicitly mention the assumption in KZG package #965

Open
ivokub opened this issue Dec 15, 2023 · 0 comments
Open

doc: explicitly mention the assumption in KZG package #965

ivokub opened this issue Dec 15, 2023 · 0 comments

Comments

@ivokub
Copy link
Collaborator

ivokub commented Dec 15, 2023

See #949:

Make the assumption that gammai[0] == 1 explicit in the method documentation.

In general I agree that we can avoid scalarmul for the first point/scalar (scalar == 1), but I think we would have to make the assumption explicit somehow. Maybe even adding a doc comment? So when we would call the method with non-one first scalar we would know where to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant