New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: `api.FromBinary(api.ToBinary(constant))` is not a constant #913

Open

gbotrel opened this issue Nov 13, 2023 · 0 comments

Labels

good first issue perf

Collaborator

gbotrel commented Nov 13, 2023 •

edited

divisor := api.Sub(api.FromBinary(api.ToBinary(constant)...), api.FromBinary(api.ToBinary(constant)...))

Should output a constant, and does not. Not a soundness issue -- but we generate useless constraints in that case.

Thanks to @wuestholz for reporting.

The text was updated successfully, but these errors were encountered:

gbotrel added good first issue perf labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment