Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roach2Heterodyne.get_measurement_blocks() block length #16

Closed
danielflanigan opened this issue May 5, 2016 · 3 comments
Closed

Roach2Heterodyne.get_measurement_blocks() block length #16

danielflanigan opened this issue May 5, 2016 · 3 comments

Comments

@danielflanigan
Copy link
Contributor

This method doesn't return 4096-sample blocks, like the corresponding methods for other roaches, and instead seems to return a number of samples that depends on the number of tone frequencies. Is it actually returning data corresponding to a certain number of packets?

There's nothing inherently wrong with this, but it's confusing. It would be very helpful to have comments for these methods.

@gitj
Copy link
Member

gitj commented May 5, 2016

The idea is that different designs have different block lengths, so
get_measurement_blocks is an expert function and get_measurement is the
high level interface. But certainly the documentation can be improved.
On May 4, 2016 8:53 PM, "danielflanigan" notifications@github.com wrote:

This method doesn't return 4096-sample blocks, like the corresponding
methods for other roaches, and instead seems to return a number of samples
that depends on the number of tone frequencies. Is it actually returning
data corresponding to a certain number of packets?

There's nothing inherently wrong with this, but it's confusing. It would be
very helpful to have comments for these methods.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#16

@danielflanigan
Copy link
Contributor Author

Fair enough. Usually I just want get_data_seconds, but occasionally it's useful to have an easy way to get a particular number of samples.

@gitj
Copy link
Member

gitj commented May 5, 2016

@danielflanigan
Just added #17 to address this use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants