Fix fetching of AssertionError message for Python 3 #29
Conversation
Exceptions in Python 3 no longer contain a `msg` attribute. Instead the exception message is accessible from the exception object directly. In order to maintain Python 2 support, attempt to fetch the message from `e.msg` and use `str(e)` as a default if the attribute does not exist. Fixes ColtonProvias#28
alexvermeulen
force-pushed
the
ISSUE-28-attribute-error-on-validation
branch
from
6ef1542
to
d62dc25
Compare
There was a problem hiding this comment.
This isn't the best way to handle this. There's also a syntax error causing tests to fail.
There's no msg attribute on any Python exception, in 2 or 3. The best way to do this is simply raise the caught exception, i.e.
raise ValidationError(e)
As a side note, I don't think this code is executed in any tests, so there's no way to know if it's correct. I'd love if you could add some test coverage, but that's not required to get the patch landed. We do need to correctly raise the error and remove the syntax error to get this landed, though.
Thanks for submitting the patch!
|
Going to close this since it's not the right approach and there hasn't been any activity. We have issue #28 to remind us of the bug. Please feel free to reopen if you update the branch. |
Exceptions in Python 3 no longer contain a
msgattribute. Instead the exception message is accessible from the exception object directly.In order to maintain Python 2 support, attempt to fetch the message from
e.msgand usestr(e)as a default if the attribute does not exist.I was going to add a test for this but I saw all the existing tests are currently commented out. I figured you were likely doing some refactoring and hadn't gotten to the tests yet. Perhaps you are already fixing this issue as part of your work as well. Regardless, I thought I'd throw up a PR in case it is useful to you.
Fixes #28