Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: "Mobile UI" or "touchscreen UI" options in "Graphic Settings" page of Genshin Impact request. #466

Closed
XieyilinMain opened this issue May 16, 2024 · 5 comments
Closed

[Request]: "Mobile UI" or "touchscreen UI" options in "Graphic Settings" page of Genshin Impact request. #466

XieyilinMain opened this issue May 16, 2024 · 5 comments
Assignees
@bagusnl
Labels
Area: Game Settings Issue labeled for Game Settings related issues Enhancement New feature or request Fixed Issue has been fixed Game: Genshin Impact Issue labeled for Genshin Impact

Comments

@XieyilinMain
Copy link

XieyilinMain commented May 16, 2024 •
edited

Is your request related to a problem?

No

How is the feature request related to the problem?

Here are some scenario of using mobile UI on Windows version of Genshin Impact: gaming via Moonlight to cellphones, gaming on Windows pads without any keyboards.

Describe your proposed solution

Add use_mobile_platform -is_cloud 1 -platform_type CLOUD_THIRD_PARTY_MOBILE arguments may help.

args

Genshin Impact now shows touchscreen UI.

mobile UI

Describe alternatives you've considered

If this is not available in "Graphic Settings" page, demostrate these arguments in wiki is also a great idea.

Additional context

No response
@XieyilinMain XieyilinMain added the Enhancement New feature or request label May 16, 2024
@XieyilinMain XieyilinMain changed the title [Request]: "Mobile UI" or "touchscreen UI" options in "Graphic Settings" of Genshin Impact request. [Request]: "Mobile UI" or "touchscreen UI" options in "Graphic Settings" page of Genshin Impact request. May 16, 2024
@bagusnl
Copy link
Member

bagusnl commented May 16, 2024

Hi^^. Thanks for the improvement request, I'll work on it.

I wonder does other hoyo games have similar arguments override for it. So far HSR stuck at black screen using the same command arguments, and HI3 doesn't react at all with it (arguably it kinda doesn't need it because how they do their inputs)

@bagusnl bagusnl self-assigned this May 16, 2024
@bagusnl bagusnl added Fixed Issue has been fixed Game: Genshin Impact Issue labeled for Genshin Impact Area: Game Settings Issue labeled for Game Settings related issues labels May 16, 2024
@bagusnl
Copy link
Member

bagusnl commented May 16, 2024

Feature added with 4625ffa

If you want to try you can download the latest nightly here https://github.com/CollapseLauncher/Collapse/actions/runs/9113586519
Just extract and run, dont replace anything

@ubdjshdb
Copy link

ubdjshdb commented May 20, 2024 •
edited

I wonder does other hoyo games have similar arguments override for it.

Hi! Did some work figuring out what HSR requires to achieve the same result. Just specifying the platform type breaks the game because it also expects that you specify the graphics settings via the -graphics_setting argument. This will also hide the in-game graphics settings.

They are B64-encoded, so for example, to run with these graphics settings:

{"FPS": 60, "EnableVSync": true, "RenderScale": 1.0, "ResolutionQuality": 3, "ShadowQuality": 3, "LightQuality": 3, "CharacterQuality": 3, "EnvDetailQuality": 3, "ReflectionQuality": 3, "SFXQuality": 3, "BloomQuality": 3, "AAMode": 2}

you need to specify the following arguments:
StarRail.exe -is_cloud 1 -platform_type CLOUD_WEB_TOUCH -graphics_setting eyJGUFMiOiA2MCwgIkVuYWJsZVZTeW5jIjogdHJ1ZSwgIlJlbmRlclNjYWxlIjogMS4wLCAiUmVzb2x1dGlvblF1YWxpdHkiOiAzLCAiU2hhZG93UXVhbGl0eSI6IDMsICJMaWdodFF1YWxpdHkiOiAzLCAiQ2hhcmFjdGVyUXVhbGl0eSI6IDMsICJFbnZEZXRhaWxRdWFsaXR5IjogMywgIlJlZmxlY3Rpb25RdWFsaXR5IjogMywgIlNGWFF1YWxpdHkiOiAzLCAiQmxvb21RdWFsaXR5IjogMywgIkFBTW9kZSI6IDJ9.

Hope this helps!

bagusnl added a commit that referenced this issue May 20, 2024
@bagusnl
Add MobileLayout support for StarRail
3817d80 
#466
Thanks for the details @ubdjshdb
@bagusnl
Copy link
Member

bagusnl commented May 20, 2024

Thanks @ubdjshdb !

Support for mobile mode on StarRail is added
you can try by using this artifact https://github.com/CollapseLauncher/Collapse/actions/runs/9164809891

bagusnl added a commit that referenced this issue May 25, 2024
@bagusnl @transifex-integration
@neon-nyan @shatyuka @Cryotechnic
Preview 1.80.5 Release #464 from CollapseLauncher/main
1649355 
* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* FIx background handler getting disposed on MainPage reload

* Fix region combobox cannot receive input while reloading MainPage

* (GSP-SR) Clamp ShadowQuality value

#399

* Icon button adjustment

margin, alignment, size, glyph, etc

* [i18n] Localize metadata initialization messages

also for game region combobox placeholder

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* (GSP-SR) Clamp all quality values

* (GSP-SR) GraphicsQuality presets

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* (GSP-SR) Fix fullscreen inconsistency

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Adding Async JSONSerializer helper for Stream

* Use nullable assignment for game package return list

* Update stamp file instead of redownloading if certain config has changed

* Update SharpDiscordRPC submodule

* Adjustment on CDN RadioButtons style

* Adjustment on CDN RadioButtons style (pt. 2)

* (GSP) Fix resolution related crash in RDP session

* (CodeQA) ISULR

- Suppress warnings
- Reformat
- Adjust nullables

* Update EncTool

* [skip ci] Update Checkout CI and add PR template

* [skip ci] Update formatting error on PR template

* Add ``PreventSleep()`` to prevent Windows' sleep routine

Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>

* (GSP) Fix root cause of resolution related crash in RDP session

* Implement PreventSleep() on needed methods

* (GSP) Implement mobile layout mode

Only for GI for now

* (GSP) Add delay game launch function on pre launch command

* Dont catch cancellation exception on PreventSleep

* Show nav sidebar only on hover

* Add drop shadow to nav button

* (HI3 Repair) Throw if asset key is not found

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* Add MobileLayout support for StarRail

#466
Thanks for the details @ubdjshdb

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [HSR Settings] Update localization text for 120FPS option selector

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* HoYoPlay API Adjustments (#465)

* Change EncTool path

* Use async stream for loading background files

* Fix escaped JSON characters don't get parsed correctly

* Move constant JSON class into inner extension class

* Refactor API Loaders

Using the new ILauncherApi to unify the integration with other types of API (like: HoYoPlay)

* Adding basic HYP to Sophon pkg resource conversion

+ Borrowing HSR version check and game settings for now.

* Adding background image support for HoYoPlay API

* Adding news and carousel panel support for HoYoPlay API

* Fix false Base64 detection on ``GetServeV3String()``

This was causing some installation detection issues where some region/version check related string is falsely detected as Base64 and make the string rendered incorrectly

* Fix some typo and avoid unnecessary buffer alloc on ``ServeV3Data``

+ Also fixes throw while checking for non-existence pre-load property

* Fix crash while changing launcher release channel

* Fix background throw due to null preload property

* Adding new decompressor for .zip package files

Adding USENEWZIPDECOMPRESS to use SharpCompress decompressor with multi-thread zip decompress support.

* Avoid null packages to be proceeded

* Check availability for cache type: "Event" with DLM = 2

* Fix Hi3 Game Repair for version: ``Thelema``

* Re-adding checks if the normal metadata file exists (Hi3)

* FIx "Check Update" button status's center position

* Adjust windows title-bar button style

* Extend maximum threads for download to 16

* Fix TextFillColorBrush on update status button

* Use GetURLStatusCode to check URL status on repair/cache

* Use ``Enum.GetValues<T>()`` instead of ``Enum.GetValues(typeof(T))``

* Fix last exception in ``RetryTimeoutAfter()`` not getting thrown

* Fix threading issues on Install, Repair and Cache mechanism

* Fix Infinity and NaN numbers in ``TotalPerfileProgress``

* Use ``UnNaNInfinity()`` in ``UpdateProgress()``

* Fix data corruption while performing game data migration

* Fix max session exception on Hi3Helper.Http

* Fix float/double to TimeSpan number conversion

This due to the number being a negative infinity

* Bump version

* Add Sophon submodule

* FIx background handler getting disposed on MainPage reload

* Fix region combobox cannot receive input while reloading MainPage

* Adding Sophon testing/usage sample

* Adding Async JSONSerializer helper for Stream

* Use nullable assignment for game package return list

* Update stamp file instead of redownloading if certain config has changed

* Update SharpDiscordRPC submodule

* Adding Sophon submodule and its testing project

* Add new Sophon Chunk download mechanism

* (GSP-SR) Clamp ShadowQuality value

#399

* [i18n] Localize metadata initialization messages

also for game region combobox placeholder

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* (GSP-SR) Clamp all quality values

* (GSP-SR) GraphicsQuality presets

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Localize Discord RPC Game/Region strings

* Add a way to skip audio patch

Currently only for Star Rail

* (CDN) Add Coding mirror

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* Update NuGet Dependencies

H.NotifyIcon
https://www.nuget.org/packages/H.NotifyIcon.WinUI#releasenotes-body-tab

HtmlAgilityPack
https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.11.61

WASDK
https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#version-153-15240428000

TaskScheduler
https://github.com/dahall/TaskScheduler/releases/tag/v2.11.0

* Update NuGet

* Fix build configuration

* Adjustment on CDN RadioButtons style

* Adjustment on CDN RadioButtons style (pt. 2)

* (GSP-SR) Fix fullscreen inconsistency

* Update sophon submodule

* Update sophon submodule

* Add ``PreventSleep()`` to prevent Windows' sleep routine

Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>

* [TaskExtensions] Throw inner exception if completed task is faulty

* [HYP] Add parser for social media icons

* [Sophon] Fix crash caused by empty URL conditions in news API

* [UI] Adjust the social media flyout style

* Implement PreventSleep() on needed methods

* Update GitInfo NuGet and package lock file

* [TaskExtensions] Use the new ``WaitForRetryAsync`` for retrying task

* [UI] Fix inconsistent foreground color for socmed's QR title

* (GSP) Implement mobile layout mode

Only for GI for now

* (GSP) Add delay game launch function on pre launch command

* Update submodules and NuGet

* Use custom style for ``ImageEx``

* Remove unnecessary ``Console.WriteLine()`` under ``CurrentMetadataConfig``

* Use custom style for ``ImageEx`` pt. 2

* Use async WriteLine for logger (also uses .Error and .Out to write)

* Hi3Helper.Sophon adjustment

* Dont catch cancellation exception on PreventSleep

* Show nav sidebar only on hover

* Add drop shadow to nav button

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Update Hi3Helper.Http submodule

* Fix fallback translation for MobileLayout text

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove deprecated CDN (Bitbucket)

* UI Adjustments

+ Adding FontSize property to the CompressedTextBlock
+ Unify ApplyShadow to be used by other elements, moving the code to UIElementExtensions with some changes.
+ Adding StartAnimationDetached to AnimationHelper extension
+ Adjust element sizes on both Normal and Small Size window
+ Minor adjustment on brushes
+ Move the playtme button beside the Quick Settings and Community Tools button
+ Adding shadows to navigation menu icons (by: @shatyuka) and social media icons
+ New layout and adjustments for Carousel and News panel
+ Adjustment on Install, Update and Start game button
+ Adding loading animation while loading ImageEx element

Co-Authored-By: Shatyuka <shatyuka@qq.com>

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove unnecessary Lottie package

* Adjust Preload box dialog UI

* Use current thread for animation compositor

* Adjust preload button style to ``AcrylicButtonStyle``

* Use current thread for animation compositor (pt. 2)

* Add 500 ms delay before side panel animation is triggered

* Fix crash on starting animation with no access to thread

* Minor adjustment on loading frame

* Fix task not retrying due to cancellation from linked source

* Fix retry mechanism on API loading not working

* Adjust DisconnectedPage style

* Add HoYoPlay featured event icon and styles

* Fix installation progress bar style

* Update sophon and HYP install mechanism

* fix typo

* change insufficient drive space dialog required type

* fix incorrect package size indicators to the user

THANKS MICROSOFT VERY COOL

This hopefully fixes #445

* update submodule

* update submodule

wrong commit hash 😓

---------

Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Shatyuka <shatyuka@qq.com>
Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Ron Friedman <cryogen65@gmail.com>

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Shatyuka <shatyuka@qq.com>
Co-authored-by: Ron Friedman <cryogen65@gmail.com>
@bagusnl
Copy link
Member

bagusnl commented May 25, 2024

An update that include this fix already been published on 1.80.5, we'll close this issue ticket.
If you have any problem, don't hesitate to reopen this or make a new ticket.

Thank you for using Collapse Launcher <3

@bagusnl bagusnl closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagusnl bagusnl

Labels
Area: Game Settings Issue labeled for Game Settings related issues Enhancement New feature or request Fixed Issue has been fixed Game: Genshin Impact Issue labeled for Genshin Impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bagusnl @ubdjshdb @XieyilinMain