[Bug]: if you have some files downloaded already, it wont let you continue if the free space is lower than required space

[anispwyn]

Affected Version

360222b

Bug Behavior

when you have some of the game files downloaded, you pause and then when you decide to continue, it wont let you continue if your free space is lower than required space

Expected Behavior

it (collapse) count the downloaded files and then make the required disk space lower so it can continue

Steps to reproduce

1. make ur drive almost full, but enough to download 1 game
2. download the game, wait until the disk space is lower than required space
3. when your free space is lower than required space, pause and continue
4. the popups appear

Related Issues

No response

Screenshot(s)

Additional Information

No response

[bagusnl]

Func InstallManagerBase.CheckDriveFreeSpace

Collapse/CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs

Lines 1800 to 1821 in 360222b

	private async ValueTask CheckDriveFreeSpace(UIElement Content, List<GameInstallPackage> packageList)
	{
	// Get the information about the disk
	DriveInfo _DriveInfo = new DriveInfo(_gamePath);
	// Get the total of required size on every package
	long RequiredSpace = packageList.Sum(x => x.SizeRequired);
	long ExistingPackageSize = packageList.Sum(x => x.Segments != null ? x.Segments.Sum(y => GetExistingPartialDownloadLength(y.PathOutput, y.Size)) : GetExistingPartialDownloadLength(x.PathOutput, x.Size));
	// Get the total free space of the disk
	long DiskSpace = _DriveInfo.TotalFreeSpace;
	LogWriteLine($"Total free space required: {ConverterTool.SummarizeSizeSimple(RequiredSpace)} with {_DriveInfo.Name} remaining free space: {ConverterTool.SummarizeSizeSimple(DiskSpace)}", LogType.Default, true);
	// Check if the disk space is insufficient, then show the dialog.
	if (DiskSpace < (RequiredSpace - ExistingPackageSize))
	{
	string errStr = $"Free Space on {_DriveInfo.Name} is not sufficient! (Free space: {DiskSpace}, Req. Space: {RequiredSpace - ExistingPackageSize}, Drive: {_DriveInfo.Name})";
	LogWriteLine(errStr, LogType.Error, true);
	await Dialog_InsufficientDriveSpace(Content, DiskSpace, RequiredSpace - ExistingPackageSize, _DriveInfo.Name);
	throw new TaskCanceledException(errStr);
	}
	}

Unsure what's wrong with it... My sleepy brain tells something about segments calculation in segmented package (eg Genshin install packages) is not working correctly

Cc @neon-nyan

[Cryotechnic]

Issue should be addressed in 0ce8b93. You can download the build artifact here and let us know if you still have the issue.