Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Honkai: Star Rail, Inconsistently Global Graphics Settings: Character Settings in game High, but in Collapse is Very High #399

Closed
IRedDragonICY opened this issue Feb 11, 2024 · 11 comments
Assignees
Labels
Area: Game Settings Issue labeled for Game Settings related issues Bug Something isn't working Enhancement New feature or request Fixed Issue has been fixed Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail

Comments

@IRedDragonICY
Copy link

Affected Version

Collapse 1.73.3 Preview

Bug Behavior

DxDiag.txt

Expected Behavior

Add selection on Character Settings in game

  1. Low
  2. Medium
  3. High

If we select High, it must High to in Global Graphics Settings: Character Settings

Steps to reproduce

Change In game settings into Very high
The max Character Quality is high
after close Honkai: Star Rail, save settings in Collapse not same as in game Graphics Settings

Related Issues

No response

Screenshot(s)

In game
image
Collapse Launcher Settings
image

Additional Information

No response

@IRedDragonICY IRedDragonICY added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Feb 11, 2024
@bagusnl bagusnl added Bug Something isn't working Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail Area: Game Settings Issue labeled for Game Settings related issues and removed Needs Triaging This issue needs the developer's attention to sort & prioritize. labels Feb 11, 2024
@bagusnl bagusnl self-assigned this Feb 11, 2024
@bagusnl
Copy link
Member

bagusnl commented Feb 12, 2024

Heya!

Thank you for submitting bug report for Collapse~ I have sent a fix commit on e228c55
As the fix is under #398 it might need to take a bit until it gets merged into main and hopefully we can include the fix on next preview version !

@neon-nyan
Copy link
Member

Hi there,
This issue has been fixed as per latest update, 1.73.4 for both Stable and Preview releases.
Please make sure you have your launcher up-to-date to receive the fix and some new features.

Closing this issue for now and feel free to reopen the issue if you feel that the issue hasn't been resolved.

@neon-nyan neon-nyan added the Enhancement New feature or request label Mar 1, 2024
@IRedDragonICY
Copy link
Author

IRedDragonICY commented May 10, 2024

@neon-nyan the bug occurs again
Collapse Launcher 1.80.4 Preview
image
Graphics Settings
image
image
it's show very high, but Game Option is High

@bagusnl
Copy link
Member

bagusnl commented May 10, 2024

Will investigate, thanks for the heads up!

@bagusnl bagusnl reopened this May 10, 2024
@bagusnl
Copy link
Member

bagusnl commented May 11, 2024

After investigating I can't seem to trigger the same bug, tho I'll make a clamp so it will only show max High on Collapse

bagusnl added a commit that referenced this issue May 11, 2024
@bagusnl bagusnl added the Fixed Issue has been fixed label May 11, 2024
@shatyuka
Copy link
Contributor

Almost forgot about this XD. Can be reproduced here (or rather, never worked).

@shatyuka shatyuka self-assigned this May 11, 2024
@shatyuka shatyuka removed the Fixed Issue has been fixed label May 11, 2024
@shatyuka
Copy link
Contributor

@IRedDragonICY Can you provide the registry of game graphics settings?
Run the following command in PowerShell:

[Text.Encoding]::UTF8.GetString((Get-ItemPropertyValue "HKCU:\Software\miHoYo\Star Rail" GraphicsSettings_Model_h2986158309))

@shatyuka
Copy link
Contributor

@IRedDragonICY
Copy link
Author

[Text.Encoding]::UTF8.GetString((Get-ItemPropertyValue "HKCU:\Software\miHoYo\Star Rail" GraphicsSettings_Model_h2986158309))

uhm different regedit location so Powershell script is doesn't work
Computer\HKEY_CURRENT_USER\Software\Cognosphere\Star Rail

$path = "HKCU:\Software\Cognosphere\Star Rail"
$name = "GraphicsSettings_Model_h2986158309"

try {
    $value = Get-ItemProperty -Path $path -Name $name
    $binaryData = $value."$name"
    $stringData = [System.Text.Encoding]::UTF8.GetString($binaryData)
    $stringData
} catch {
    Write-Host "not found"
}

here is settings:
''
7B22465053223A36302C22456E61626C655653796E63223A66616C73652C2252656E6465725363616C65223A312E382C225265736F6C7574696F6E5175616C697479223A352C22536861646F775175616C697479223A352C224C696768745175616C697479223A352C224368617261637465725175616C697479223A352C22456E7644657461696C5175616C697479223A352C225265666C656374696F6E5175616C697479223A352C225346585175616C697479223A342C22426C6F6F6D5175616C697479223A352C2241414D6F6465223A312C22456E61626C654D6574616C46585355223A66616C73657D00
''

{"FPS":60,"EnableVSync":false,"RenderScale":1.8,"ResolutionQuality":5,"ShadowQuality":5,"LightQuality":5,"CharacterQuality":5,"EnvDetailQuality":5,"ReflectionQuality":5,"SFXQuality":4,"BloomQuality":5,"AAMode":1,"EnableMetalFXSU":false}

@IRedDragonICY
Copy link
Author

Try this CI build: https://github.com/CollapseLauncher/Collapse/actions/runs/9050660614

it's fixed in this build

@shatyuka shatyuka added the Fixed Issue has been fixed label May 13, 2024
bagusnl added a commit that referenced this issue May 16, 2024
bagusnl added a commit that referenced this issue May 25, 2024
* Change EncTool path

* Use async stream for loading background files

* Fix escaped JSON characters don't get parsed correctly

* Move constant JSON class into inner extension class

* Refactor API Loaders

Using the new ILauncherApi to unify the integration with other types of API (like: HoYoPlay)

* Adding basic HYP to Sophon pkg resource conversion

+ Borrowing HSR version check and game settings for now.

* Adding background image support for HoYoPlay API

* Adding news and carousel panel support for HoYoPlay API

* Fix false Base64 detection on ``GetServeV3String()``

This was causing some installation detection issues where some region/version check related string is falsely detected as Base64 and make the string rendered incorrectly

* Fix some typo and avoid unnecessary buffer alloc on ``ServeV3Data``

+ Also fixes throw while checking for non-existence pre-load property

* Fix crash while changing launcher release channel

* Fix background throw due to null preload property

* Adding new decompressor for .zip package files

Adding USENEWZIPDECOMPRESS to use SharpCompress decompressor with multi-thread zip decompress support.

* Avoid null packages to be proceeded

* Check availability for cache type: "Event" with DLM = 2

* Fix Hi3 Game Repair for version: ``Thelema``

* Re-adding checks if the normal metadata file exists (Hi3)

* FIx "Check Update" button status's center position

* Adjust windows title-bar button style

* Extend maximum threads for download to 16

* Fix TextFillColorBrush on update status button

* Use GetURLStatusCode to check URL status on repair/cache

* Use ``Enum.GetValues<T>()`` instead of ``Enum.GetValues(typeof(T))``

* Fix last exception in ``RetryTimeoutAfter()`` not getting thrown

* Fix threading issues on Install, Repair and Cache mechanism

* Fix Infinity and NaN numbers in ``TotalPerfileProgress``

* Use ``UnNaNInfinity()`` in ``UpdateProgress()``

* Fix data corruption while performing game data migration

* Fix max session exception on Hi3Helper.Http

* Fix float/double to TimeSpan number conversion

This due to the number being a negative infinity

* Bump version

* Add Sophon submodule

* FIx background handler getting disposed on MainPage reload

* Fix region combobox cannot receive input while reloading MainPage

* Adding Sophon testing/usage sample

* Adding Async JSONSerializer helper for Stream

* Use nullable assignment for game package return list

* Update stamp file instead of redownloading if certain config has changed

* Update SharpDiscordRPC submodule

* Adding Sophon submodule and its testing project

* Add new Sophon Chunk download mechanism

* (GSP-SR) Clamp ShadowQuality value

#399

* [i18n] Localize metadata initialization messages

also for game region combobox placeholder

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* (GSP-SR) Clamp all quality values

* (GSP-SR) GraphicsQuality presets

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Localize Discord RPC Game/Region strings

* Add a way to skip audio patch

Currently only for Star Rail

* (CDN) Add Coding mirror

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* Update NuGet Dependencies

H.NotifyIcon
https://www.nuget.org/packages/H.NotifyIcon.WinUI#releasenotes-body-tab

HtmlAgilityPack
https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.11.61

WASDK
https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#version-153-15240428000

TaskScheduler
https://github.com/dahall/TaskScheduler/releases/tag/v2.11.0

* Update NuGet

* Fix build configuration

* Adjustment on CDN RadioButtons style

* Adjustment on CDN RadioButtons style (pt. 2)

* (GSP-SR) Fix fullscreen inconsistency

* Update sophon submodule

* Update sophon submodule

* Add ``PreventSleep()`` to prevent Windows' sleep routine

Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>

* [TaskExtensions] Throw inner exception if completed task is faulty

* [HYP] Add parser for social media icons

* [Sophon] Fix crash caused by empty URL conditions in news API

* [UI] Adjust the social media flyout style

* Implement PreventSleep() on needed methods

* Update GitInfo NuGet and package lock file

* [TaskExtensions] Use the new ``WaitForRetryAsync`` for retrying task

* [UI] Fix inconsistent foreground color for socmed's QR title

* (GSP) Implement mobile layout mode

Only for GI for now

* (GSP) Add delay game launch function on pre launch command

* Update submodules and NuGet

* Use custom style for ``ImageEx``

* Remove unnecessary ``Console.WriteLine()`` under ``CurrentMetadataConfig``

* Use custom style for ``ImageEx`` pt. 2

* Use async WriteLine for logger (also uses .Error and .Out to write)

* Hi3Helper.Sophon adjustment

* Dont catch cancellation exception on PreventSleep

* Show nav sidebar only on hover

* Add drop shadow to nav button

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Update Hi3Helper.Http submodule

* Fix fallback translation for MobileLayout text

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove deprecated CDN (Bitbucket)

* UI Adjustments

+ Adding FontSize property to the CompressedTextBlock
+ Unify ApplyShadow to be used by other elements, moving the code to UIElementExtensions with some changes.
+ Adding StartAnimationDetached to AnimationHelper extension
+ Adjust element sizes on both Normal and Small Size window
+ Minor adjustment on brushes
+ Move the playtme button beside the Quick Settings and Community Tools button
+ Adding shadows to navigation menu icons (by: @shatyuka) and social media icons
+ New layout and adjustments for Carousel and News panel
+ Adjustment on Install, Update and Start game button
+ Adding loading animation while loading ImageEx element

Co-Authored-By: Shatyuka <shatyuka@qq.com>

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove unnecessary Lottie package

* Adjust Preload box dialog UI

* Use current thread for animation compositor

* Adjust preload button style to ``AcrylicButtonStyle``

* Use current thread for animation compositor (pt. 2)

* Add 500 ms delay before side panel animation is triggered

* Fix crash on starting animation with no access to thread

* Minor adjustment on loading frame

* Fix task not retrying due to cancellation from linked source

* Fix retry mechanism on API loading not working

* Adjust DisconnectedPage style

* Add HoYoPlay featured event icon and styles

* Fix installation progress bar style

* Update sophon and HYP install mechanism

* fix typo

* change insufficient drive space dialog required type

* fix incorrect package size indicators to the user

THANKS MICROSOFT VERY COOL

This hopefully fixes #445

* update submodule

* update submodule

wrong commit hash 😓

---------

Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Shatyuka <shatyuka@qq.com>
Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Ron Friedman <cryogen65@gmail.com>
bagusnl added a commit that referenced this issue May 25, 2024
* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* FIx background handler getting disposed on MainPage reload

* Fix region combobox cannot receive input while reloading MainPage

* (GSP-SR) Clamp ShadowQuality value

#399

* Icon button adjustment

margin, alignment, size, glyph, etc

* [i18n] Localize metadata initialization messages

also for game region combobox placeholder

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* (GSP-SR) Clamp all quality values

* (GSP-SR) GraphicsQuality presets

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* (GSP-SR) Fix fullscreen inconsistency

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Adding Async JSONSerializer helper for Stream

* Use nullable assignment for game package return list

* Update stamp file instead of redownloading if certain config has changed

* Update SharpDiscordRPC submodule

* Adjustment on CDN RadioButtons style

* Adjustment on CDN RadioButtons style (pt. 2)

* (GSP) Fix resolution related crash in RDP session

* (CodeQA) ISULR

- Suppress warnings
- Reformat
- Adjust nullables

* Update EncTool

* [skip ci] Update Checkout CI and add PR template

* [skip ci] Update formatting error on PR template

* Add ``PreventSleep()`` to prevent Windows' sleep routine

Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>

* (GSP) Fix root cause of resolution related crash in RDP session

* Implement PreventSleep() on needed methods

* (GSP) Implement mobile layout mode

Only for GI for now

* (GSP) Add delay game launch function on pre launch command

* Dont catch cancellation exception on PreventSleep

* Show nav sidebar only on hover

* Add drop shadow to nav button

* (HI3 Repair) Throw if asset key is not found

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* Add MobileLayout support for StarRail

#466
Thanks for the details @ubdjshdb

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [HSR Settings] Update localization text for 120FPS option selector

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* HoYoPlay API Adjustments (#465)

* Change EncTool path

* Use async stream for loading background files

* Fix escaped JSON characters don't get parsed correctly

* Move constant JSON class into inner extension class

* Refactor API Loaders

Using the new ILauncherApi to unify the integration with other types of API (like: HoYoPlay)

* Adding basic HYP to Sophon pkg resource conversion

+ Borrowing HSR version check and game settings for now.

* Adding background image support for HoYoPlay API

* Adding news and carousel panel support for HoYoPlay API

* Fix false Base64 detection on ``GetServeV3String()``

This was causing some installation detection issues where some region/version check related string is falsely detected as Base64 and make the string rendered incorrectly

* Fix some typo and avoid unnecessary buffer alloc on ``ServeV3Data``

+ Also fixes throw while checking for non-existence pre-load property

* Fix crash while changing launcher release channel

* Fix background throw due to null preload property

* Adding new decompressor for .zip package files

Adding USENEWZIPDECOMPRESS to use SharpCompress decompressor with multi-thread zip decompress support.

* Avoid null packages to be proceeded

* Check availability for cache type: "Event" with DLM = 2

* Fix Hi3 Game Repair for version: ``Thelema``

* Re-adding checks if the normal metadata file exists (Hi3)

* FIx "Check Update" button status's center position

* Adjust windows title-bar button style

* Extend maximum threads for download to 16

* Fix TextFillColorBrush on update status button

* Use GetURLStatusCode to check URL status on repair/cache

* Use ``Enum.GetValues<T>()`` instead of ``Enum.GetValues(typeof(T))``

* Fix last exception in ``RetryTimeoutAfter()`` not getting thrown

* Fix threading issues on Install, Repair and Cache mechanism

* Fix Infinity and NaN numbers in ``TotalPerfileProgress``

* Use ``UnNaNInfinity()`` in ``UpdateProgress()``

* Fix data corruption while performing game data migration

* Fix max session exception on Hi3Helper.Http

* Fix float/double to TimeSpan number conversion

This due to the number being a negative infinity

* Bump version

* Add Sophon submodule

* FIx background handler getting disposed on MainPage reload

* Fix region combobox cannot receive input while reloading MainPage

* Adding Sophon testing/usage sample

* Adding Async JSONSerializer helper for Stream

* Use nullable assignment for game package return list

* Update stamp file instead of redownloading if certain config has changed

* Update SharpDiscordRPC submodule

* Adding Sophon submodule and its testing project

* Add new Sophon Chunk download mechanism

* (GSP-SR) Clamp ShadowQuality value

#399

* [i18n] Localize metadata initialization messages

also for game region combobox placeholder

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* (GSP-SR) Clamp all quality values

* (GSP-SR) GraphicsQuality presets

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Localize Discord RPC Game/Region strings

* Add a way to skip audio patch

Currently only for Star Rail

* (CDN) Add Coding mirror

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* Update NuGet Dependencies

H.NotifyIcon
https://www.nuget.org/packages/H.NotifyIcon.WinUI#releasenotes-body-tab

HtmlAgilityPack
https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.11.61

WASDK
https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#version-153-15240428000

TaskScheduler
https://github.com/dahall/TaskScheduler/releases/tag/v2.11.0

* Update NuGet

* Fix build configuration

* Adjustment on CDN RadioButtons style

* Adjustment on CDN RadioButtons style (pt. 2)

* (GSP-SR) Fix fullscreen inconsistency

* Update sophon submodule

* Update sophon submodule

* Add ``PreventSleep()`` to prevent Windows' sleep routine

Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>

* [TaskExtensions] Throw inner exception if completed task is faulty

* [HYP] Add parser for social media icons

* [Sophon] Fix crash caused by empty URL conditions in news API

* [UI] Adjust the social media flyout style

* Implement PreventSleep() on needed methods

* Update GitInfo NuGet and package lock file

* [TaskExtensions] Use the new ``WaitForRetryAsync`` for retrying task

* [UI] Fix inconsistent foreground color for socmed's QR title

* (GSP) Implement mobile layout mode

Only for GI for now

* (GSP) Add delay game launch function on pre launch command

* Update submodules and NuGet

* Use custom style for ``ImageEx``

* Remove unnecessary ``Console.WriteLine()`` under ``CurrentMetadataConfig``

* Use custom style for ``ImageEx`` pt. 2

* Use async WriteLine for logger (also uses .Error and .Out to write)

* Hi3Helper.Sophon adjustment

* Dont catch cancellation exception on PreventSleep

* Show nav sidebar only on hover

* Add drop shadow to nav button

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in zh_CN

100% reviewed source file: 'en_US.json'
on 'zh_CN'.

* [skip ci] Sync translation Translate en_US.json in ja_JP

100% reviewed source file: 'en_US.json'
on 'ja_JP'.

* [skip ci] Sync translation Translate en_US.json in es_419

100% reviewed source file: 'en_US.json'
on 'es_419'.

* Update Hi3Helper.Http submodule

* Fix fallback translation for MobileLayout text

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove deprecated CDN (Bitbucket)

* UI Adjustments

+ Adding FontSize property to the CompressedTextBlock
+ Unify ApplyShadow to be used by other elements, moving the code to UIElementExtensions with some changes.
+ Adding StartAnimationDetached to AnimationHelper extension
+ Adjust element sizes on both Normal and Small Size window
+ Minor adjustment on brushes
+ Move the playtme button beside the Quick Settings and Community Tools button
+ Adding shadows to navigation menu icons (by: @shatyuka) and social media icons
+ New layout and adjustments for Carousel and News panel
+ Adjustment on Install, Update and Start game button
+ Adding loading animation while loading ImageEx element

Co-Authored-By: Shatyuka <shatyuka@qq.com>

* [skip ci] Sync translation Translate en_US.json in id_ID

100% reviewed source file: 'en_US.json'
on 'id_ID'.

* Remove unnecessary Lottie package

* Adjust Preload box dialog UI

* Use current thread for animation compositor

* Adjust preload button style to ``AcrylicButtonStyle``

* Use current thread for animation compositor (pt. 2)

* Add 500 ms delay before side panel animation is triggered

* Fix crash on starting animation with no access to thread

* Minor adjustment on loading frame

* Fix task not retrying due to cancellation from linked source

* Fix retry mechanism on API loading not working

* Adjust DisconnectedPage style

* Add HoYoPlay featured event icon and styles

* Fix installation progress bar style

* Update sophon and HYP install mechanism

* fix typo

* change insufficient drive space dialog required type

* fix incorrect package size indicators to the user

THANKS MICROSOFT VERY COOL

This hopefully fixes #445

* update submodule

* update submodule

wrong commit hash 😓

---------

Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Shatyuka <shatyuka@qq.com>
Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Ron Friedman <cryogen65@gmail.com>

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com>
Co-authored-by: Shatyuka <shatyuka@qq.com>
Co-authored-by: Ron Friedman <cryogen65@gmail.com>
@bagusnl
Copy link
Member

bagusnl commented May 25, 2024

An update that include this fix already been published on 1.80.5, we'll close this issue ticket.
If you have any problem, don't hesitate to reopen this or make a new ticket.

Thank you for using Collapse Launcher <3

@bagusnl bagusnl closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Game Settings Issue labeled for Game Settings related issues Bug Something isn't working Enhancement New feature or request Fixed Issue has been fixed Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail
Projects
None yet
Development

No branches or pull requests

4 participants