Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize JSON Responses across APIs #53

Open
lobodemonte opened this issue Feb 11, 2020 · 2 comments
Open

Standardize JSON Responses across APIs #53

lobodemonte opened this issue Feb 11, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@lobodemonte
Copy link

Currently all of RC calls return the json format we receive from each API provider, which leads to a lot of work to access common field on the user end.
We need to provide instead a common response object that has methods for accessing these fields (like doi, title, authors, etc.)

@lobodemonte lobodemonte added the enhancement New feature or request label Feb 11, 2020
@lobodemonte lobodemonte self-assigned this Feb 11, 2020
@ceteri
Copy link
Contributor

ceteri commented Feb 11, 2020

The master branch as of release v1.1.1 has the _ScholInfraResponse class which we can use for this.

We can wrap the returned params meta, timing, message in that -- then add accessor methods. It could be serialized as JSON, for storing results during the workflow steps in RCGraph

@lobodemonte
Copy link
Author

Forgot to also include these changes into the original release 1.2
They will need to be included for this issue to be closed
#70

@lobodemonte lobodemonte removed their assignment Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants