Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended uses of overlapping spans in SpanLabelView where necessary #690

Open
ChaseDuncan opened this issue Sep 4, 2018 · 0 comments
Labels

Comments

@ChaseDuncan
Copy link
Contributor

Issue 665 fix a bug which allowed the overlapping spans check in SpanLabelView to be gotten around
by using SpanLabelView.addConstituent(Constituent). This fix broke some code because there were instances of the overlapping spans flag being set to false, i.e. declaring an intent to not allow overlapping spans, but overlapping spans were still being used.

In order to close the ticket we simply set the flag to true in all of these cases. Doing so does not change the behavior of the code. Still, it should be determined what was actually intended in these cases and make sure that the code reflects what was intended.

These are the files which use SpanLabelView and were changed:

corpusreaders/src/main/java/edu/illinois/cs/cogcomp/nlp/corpusreaders/ereReader/ERENerReader.java md/src/main/java/org/cogcomp/md/BIOCombinedReader.java
md/src/main/java/org/cogcomp/md/BIOReader.java
md/src/main/java/org/cogcomp/md/ColumnFormatReader.java
md/src/main/java/org/cogcomp/md/MentionAnnotator.java

@ChaseDuncan ChaseDuncan added the bug label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant