Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post/page settings translation issue #4171

Open
irinelenache opened this issue Dec 11, 2023 · 0 comments
Open

Post/page settings translation issue #4171

irinelenache opened this issue Dec 11, 2023 · 0 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@irinelenache
Copy link
Contributor

Description

A user pointed out that the post types can't be translated in this code section:

public function add() {
$post_type = 'Neve';
$post_type_from_db = get_post_type();
if ( $post_type_from_db ) {
$post_type = ucfirst( $post_type_from_db );
}
add_meta_box(
'neve-page-settings',
sprintf(
/* translators: %s - post type */
__( '%s Settings', 'neve' ),
$post_type
),
array( $this, 'render_metabox' ),
array( 'post', 'page', 'product' ),
'side',
'default',
array(
'__back_compat_meta_box' => true,
)
);
if ( $this->is_gutenberg_active() ) {
add_meta_box(
'neve-page-settings-notice',
sprintf(
/* translators: %s - post type */
__( '%s Settings', 'neve' ),
$post_type
),
array( $this, 'render_metabox_notice' ),
Supported_Post_Types::get( 'block_editor' ),
'side',
'default',
array(
'__back_compat_meta_box' => false,
)
);
}
}

Ticket - https://wordpress.org/support/topic/translation-issue-with-s-settings/

Step-by-step reproduction instructions

  1. Check the ticket

Screenshots, screen recording, code snippet or Help Scout ticket

https://wordpress.org/support/topic/translation-issue-with-s-settings/

Environment info

No response

Is the issue you are reporting a regression

No

@irinelenache irinelenache added bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

No branches or pull requests

1 participant