Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Update NPM packages and JS build #4143

Open
Soare-Robert-Daniel opened this issue Nov 15, 2023 · 0 comments · May be fixed by #4144
Open

[Dev] Update NPM packages and JS build #4143

Soare-Robert-Daniel opened this issue Nov 15, 2023 · 0 comments · May be fixed by #4144
Assignees
Labels
x-large (1w) - This label is used for issues that can be completed within 1 week or less.

Comments

@Soare-Robert-Daniel
Copy link
Contributor

We should update our NPM packages since libs like the currently used version of node-sass does not work with the newer version of Node and Python.

We can update the node-sass to an updated version to support the newer version, but the job is half done since this libs is not longer supported for the newer version of SASS.

If we switch to recommended lib sass, we even get warnings like:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, $items) or calc(100% / $items)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
8 │             max-width: (100%/$items - 2);
  │                         ^^^^^^^^^^^
  ╵
    assets/scss/components/elements/_gallery.scss 8:16  @import
    assets/scss/style.scss 16:9                         root stylesheet

Also, this lib is not dependent on the Python version when installed like the old one.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 15, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Nov 15, 2023 that will close this issue
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Nov 15, 2023 that will close this issue
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel added the x-large (1w) - This label is used for issues that can be completed within 1 week or less. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x-large (1w) - This label is used for issues that can be completed within 1 week or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant