Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Issue with Null $wrap Property in resource API Calls #49

Open
daalvand opened this issue Feb 5, 2023 · 0 comments
Open

The Issue with Null $wrap Property in resource API Calls #49

daalvand opened this issue Feb 5, 2023 · 0 comments

Comments

@daalvand
Copy link

daalvand commented Feb 5, 2023

I have two APIs that when I call the first one, it returns a specific resource as shown below:

class FirstResource extends JsonResource
{
    public function toArray($request)
    {
        self::withoutWrapping();
        return [
            ....
        ];
    }
}

And the second API returns a resource as shown below:

class SecondResource extends JsonResource
{
    public function toArray($request)
    {
        return [
            ....
        ];
    }
}

JsonResource code (Laravel source code):

class JsonResource implements ArrayAccess, JsonSerializable, Responsable, UrlRoutable
{
    /**
     * The "data" wrapper that should be applied.
     *
     * @var string|null
     */
    public static $wrap = 'data';
    //...
}

The problem is that when these calls are made, the $wrap property in the second resource becomes null, even though its value should be equal to 'data', causing the test to fail.

Actually, the first resource affects the second resource on separate APIs!!!

Why it happens ?

I think Laravel-module makes just one instance of the app for all tests, so this conflict happens, am I right?

It can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant