Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Laravel exception handling #2

Open
FatBoyXPC opened this issue Jun 5, 2020 · 1 comment
Open

Disable Laravel exception handling #2

FatBoyXPC opened this issue Jun 5, 2020 · 1 comment

Comments

@FatBoyXPC
Copy link

Laravel v7.10.3

I was trying to $i->disableExceptionHandling() and noticed that it wasn't actually getting taken care of. I would gladly PR this as it seems like a simple change:

https://github.com/Codeception/module-laravel5/blob/bd2c604e8aa02d2b24737de01c6716473e8db96c/src/Codeception/Lib/Connector/Laravel5/ExceptionHandlerDecorator.php#L74

Any objections to removing the 2nd condition from the if statement? From a "disable exception handling" standpoint I don't care if it's a laravel or symfony exception, I just want it to get re-thrown.

Any objections to this change?

It looks like @janhenkgerritsen is familiar with these issues in some capacity, so I am tagging for visibility!

@DavertMik DavertMik transferred this issue from Codeception/module-laravel5 Dec 26, 2020
@TavoNiievez
Copy link
Member

hey @FatBoyXPC, version 2.0 of this module is now available, and more importantly, we now have an updated test project to work with!

The disableExceptionHandling method is one of the few that could not be tested, if you know how to fix it please feel free to send a PR.

I would suggest you take a look at the new contribution guide if that's the case.

As long as the tests pass and you can justify the change, feel free to improve the logic as much as you want.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants