Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Python Plotly .line() #4556

Open
2 of 3 tasks
codecademy-docs opened this issue Apr 22, 2024 · 9 comments · May be fixed by #4577
Open
2 of 3 tasks

[Term Entry] Python Plotly .line() #4556

codecademy-docs opened this issue Apr 22, 2024 · 9 comments · May be fixed by #4577
Assignees
Labels
claimed Issue is claimed and closed to further assignment good first issue Good for newcomers new entry New entry or entries python Python entries

Comments

@codecademy-docs
Copy link
Collaborator

codecademy-docs commented Apr 22, 2024

Reason/inspiration (optional)

We would like a new term entry in the Data Visualization concept for Plotly: .line(). The entry should go in a new file under docs/content/plotly/concepts/express/terms/line/line.md

The entry should describe the term and how it is used. Also include:

  • An introductory paragraph that describes the concept
  • A 'Syntax' section that includes the syntax for the concept (if applicable)
  • An 'Example' section that shows the concept in use

Please refer to the entry templates, content standards, and markdown style guide when working on the PR for this issue.

Entry Type (select all that apply)

New Term for Existing Concept Entry

Code of Conduct

  • By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • Labels added
  • Issue is assigned
@codecademy-docs codecademy-docs added good first issue Good for newcomers new entry New entry or entries python Python entries labels Apr 22, 2024
@Jesuscg25
Copy link

I am interested in taking this issue on.

@mamtawardhani
Copy link
Collaborator

Hey @Jesuscg25, you're assigned. In addition to the documents linked in the description, please also look at our Contribution Guide if you haven't already. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

Is this your first contribution to Codecademy Docs? If so, we're curious to know how you found out about contributing to Docs.

@mamtawardhani mamtawardhani added the claimed Issue is claimed and closed to further assignment label Apr 25, 2024
@Jesuscg25
Copy link

Hey @Jesuscg25, you're assigned. In addition to the documents linked in the description, please also look at our Contribution Guide if you haven't already. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

Is this your first contribution to Codecademy Docs? If so, we're curious to know how you found out about contributing to Docs.

Nice to meet you!

Yes, it is my first time contributing to Codecademy Docs, and that's because I'm currently doing the Git & GitHub course on CodeCademy and one part of the training is contributing to the repo.

@Jesuscg25 Jesuscg25 linked a pull request Apr 25, 2024 that will close this issue
@mamtawardhani
Copy link
Collaborator

Hey @Jesuscg25 Please re-review the path once, it has been updated. Thanks!

@Jesuscg25
Copy link

Hey @Jesuscg25 Please re-review the path once, it has been updated. Thanks!

Hey @mamtawardhani, my apologies, what is left to do here?

@mamtawardhani
Copy link
Collaborator

Hey @Jesuscg25, the path of the file has been updated in the description, do take a look at the path needed for the file, before submitting the Pull Request :)

@Jesuscg25
Copy link

Hey @Jesuscg25, the path of the file has been updated in the description, do take a look at the path needed for the file, before submitting the Pull Request :)

Hi @mamtawardhani I guess the path is wrong because the description indicates:
docs/content/plotly/concepts/express/terms/line/line.md
but the carpet python is missing, I guess it should be:
docs/content/python/plotly/concepts/express/terms/line/line.md
or should I keep the specified path?

@Sriparno08
Copy link
Collaborator

Hey @Jesuscg25, the current path is docs/content/plotly/concepts/express/terms/line/line.md, which matches with the description. You can check it by going to the 'Files changed' tab in the associated PR. So, there is no action needed from your side.

@Jesuscg25
Copy link

Hey @Jesuscg25, the current path is docs/content/plotly/concepts/express/terms/line/line.md, which matches with the description. You can check it by going to the 'Files changed' tab in the associated PR. So, there is no action needed from your side.

Thank you for explaining @Sriparno08!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed Issue is claimed and closed to further assignment good first issue Good for newcomers new entry New entry or entries python Python entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants