Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create comments.md under postgresql #4540

Merged
merged 11 commits into from May 14, 2024
Merged

Create comments.md under postgresql #4540

merged 11 commits into from May 14, 2024

Conversation

thiennguyen93
Copy link
Contributor

@thiennguyen93 thiennguyen93 commented Apr 16, 2024 •
edited

Description

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@thiennguyen93 thiennguyen93 mentioned this pull request Apr 16, 2024
Closed
3 tasks
@letsbuildanything letsbuildanything self-assigned this Apr 16, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@letsbuildanything letsbuildanything added new entry New entry or entries status: under review Issue or PR is currently being reviewed postgresql Postgresql labels Apr 16, 2024
@thiennguyen93
Copy link
Contributor Author

CLA has been signed. However, license/cla is still pending

@letsbuildanything
Copy link
Collaborator

@thiennguyen93, it appears that you've submitted this PR using two accounts. Therefore, please sign this CLA with both of your accounts, or alternatively, close this and resubmit a new PR using only a single account.

@thiennguyen93
Copy link
Contributor Author

Everything is good know

@thiennguyen93
Copy link
Contributor Author

@letsbuildanything Please help me review this one

letsbuildanything
letsbuildanything requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiennguyen93, Thank you for contributing to the Codecademy docs!
I've requested below few changes. Please make them as soon as possible.

content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
content/postgresql/concepts/comments/comments.md Outdated Show resolved Hide resolved
@letsbuildanything letsbuildanything linked an issue Apr 24, 2024 that may be closed by this pull request
[Concept Entry] Postgresql comments #4535
Closed
3 tasks
@thiennguyen93
Copy link
Contributor Author

@letsbuildanything Thank you for your code reviews. I have made some changes to fix all.
Thank again.

letsbuildanything
letsbuildanything approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiennguyen93
It seems ready for the next review.

@mamtawardhani mamtawardhani added the status: under review Issue or PR is currently being reviewed label May 13, 2024
@mamtawardhani mamtawardhani self-assigned this May 14, 2024
mamtawardhani
mamtawardhani approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiennguyen93 Thank you for contributing to Codecademy Docs!

The entry looks good to me.

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 14, 2024
@mamtawardhani mamtawardhani merged commit 0a04ccf into Codecademy:main May 14, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @thiennguyen93
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/postgresql/comments

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@letsbuildanything letsbuildanything letsbuildanything approved these changes

Assignees

@mamtawardhani mamtawardhani

@letsbuildanything letsbuildanything

Labels
new entry New entry or entries postgresql Postgresql status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Postgresql comments
5 participants
@thiennguyen93 @CLAassistant @letsbuildanything @mamtawardhani @thiennguyen-pp