Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized workspace states are incompatible after disabling the package #90

Open
jbergens opened this issue Mar 15, 2021 · 1 comment
Assignees
Labels
atom Heavily involves the Atom API bug Something isn't working known-hard

Comments

@jbergens
Copy link

I tried to disable code-ribbon (from Atom but the change is visible in config.cson).

This broke Atom completely. When I try to open it there is only a black window without any files, treeview or anything else and it does not load anything even if I wait for 2 minutes.

@robobenklein
Copy link
Member

When you disable CR from Atom's package manager it can restore the state of the workspace when you installed it, but due to an Atom limitation we can't fix the serialized state for closed / inactive workspaces.

Launching atom with the --clear-window-state flag removes all these old saved workspace layouts that might still be looking for CodeRibbon-specific patches / layouts. This is the most straightforward solution right now.

We can fix the current / active / open workspace when the package is disabled, but the best I can think of for fixing closed / inactive workspaces with serialized CR elements in them would be to send a notification to the user when the package is disabled as a reminder to clear the window state.

I think this might warrant a change to upstream Atom, something like a failsafe in case Atom can't find the deserializer for a no-longer-active package.

@robobenklein robobenklein self-assigned this Mar 16, 2021
@robobenklein robobenklein added atom Heavily involves the Atom API bug Something isn't working known-hard labels Mar 16, 2021
@robobenklein robobenklein changed the title Disabling the package breaks Atom Serialized workspace states are incompatible after disabling the package May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom Heavily involves the Atom API bug Something isn't working known-hard
Projects
None yet
Development

No branches or pull requests

2 participants