Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay decorations use incorrect absolute pixel placement: relative to wrong parent #76

Open
robobenklein opened this issue Nov 15, 2020 · 1 comment
Assignees
Labels
atom Heavily involves the Atom API bug Something isn't working known-hard
Milestone

Comments

@robobenklein
Copy link
Member

https://philipwalton.com/articles/what-no-one-told-you-about-z-index/

turns out new stacking contexts are created by the patches since will-change: transform causes the css transform property to apply without a value, creating the new stacking (and thus positioning) context from the patch

the texteditorcomponent overlay decoration pixel values need to be offset by the patch's client position relative to the parent stacking context in the OverlayComponent's update

@robobenklein robobenklein added bug Something isn't working atom Heavily involves the Atom API known-hard labels Nov 15, 2020
@robobenklein robobenklein added this to the Version 1 milestone Nov 15, 2020
@robobenklein robobenklein self-assigned this Nov 15, 2020
@robobenklein robobenklein added this to Backlog in Task Tracking via automation Nov 15, 2020
robobenklein added a commit that referenced this issue Nov 30, 2020
@robobenklein
Copy link
Member Author

f0eecc2 works for the normal 2 patches/strip, but with only one patch in a strip it breaks again

@robobenklein robobenklein moved this from Backlog to In progress in Task Tracking Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom Heavily involves the Atom API bug Something isn't working known-hard
Projects
Task Tracking
  
In progress
Development

No branches or pull requests

1 participant