Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Admin controller #58

Open
HellHunterMax opened this issue Mar 23, 2021 · 5 comments
Open

create Admin controller #58

HellHunterMax opened this issue Mar 23, 2021 · 5 comments
Labels
backend for all backend related issues

Comments

@HellHunterMax
Copy link
Collaborator

Admin should be able to create roles and assign roles to users.

admin should be able to use the Users controller.

@HellHunterMax HellHunterMax added the backend for all backend related issues label Mar 23, 2021
@HellHunterMax HellHunterMax added this to Backlog in Jokes On You via automation Mar 23, 2021
@HellHunterMax HellHunterMax moved this from Backlog to Sprint Backlog in Jokes On You Mar 23, 2021
@HellHunterMax
Copy link
Collaborator Author

I think we need a Roles Controller, not admin ?

@chrisK00
Copy link
Contributor

I think we need a Roles Controller, not admin ?

It depends. Isnt admin the only one that can create roles? Not sure what purpose rolescontroller would have since the auth will take care of authentication

@HellHunterMax
Copy link
Collaborator Author

I think we need a Roles Controller, not admin ?

It depends. Isnt admin the only one that can create roles? Not sure what purpose rolescontroller would have since the auth will take care of authentication

Well admin should be a role by itself and admin should be authorized to do the creation and modification of roles ?
Ill have to read up on roles.
Do you still have the link for the roles

@HellHunterMax
Copy link
Collaborator Author

HellHunterMax commented Mar 23, 2021

scrap that we should have fixed roles ?
Lets talk about it on discord.

@chrisK00
Copy link
Contributor

I think we need a Roles Controller, not admin ?

It depends. Isnt admin the only one that can create roles? Not sure what purpose rolescontroller would have since the auth will take care of authentication

Well admin should be a role by itself and admin should be authorized to do the creation and modification of roles ?
Ill have to read up on roles.
Do you still have the link for the roles

Yes so on the AdminController we use Authorize and the "Admin" so only a authorized admin can reach the admin methods rn only add role since we will have mods aswell so a ModeratorController too. Authorizing is just done by adding that annotation in a nutshell. You might be overthinking it

@HellHunterMax HellHunterMax moved this from Sprint Backlog to Backlog in Jokes On You Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend for all backend related issues
Projects
Development

No branches or pull requests

2 participants