Launching with Optifine broken in v3.3.3

[MelonHell]

Launching with Optifine broken in v3.3.3

[13:16:18] [main/INFO]: Loading tweak class name optifine.OptiFineTweaker
[13:16:18] [main/INFO]: Using primary tweak class name optifine.OptiFineTweaker
[13:16:18] [main/INFO]: Calling tweak class optifine.OptiFineTweaker
OptiFineTweaker: acceptOptions
OptiFineTweaker: injectIntoClassLoader
OptiFine ClassTransformer
OptiFine ZIP file: D:\AppData\Roaming.meloncher\minecraft\libraries\optifine\Optifine\1.12.2_HD_U_G6_pre1\Optifine-1.12.2_HD_U_G6_pre1.jar
OptiFineTweaker: getLaunchArguments
OptiFineTweaker: getLaunchTarget
[13:16:18] [main/ERROR]: Unable to launch
java.lang.ClassNotFoundException: net.minecraft.client.main.Main
at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:186) ~[launchwrapper-of-2.2.jar:2.2]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_51]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_51]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_51]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_51]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:155) [launchwrapper-of-2.2.jar:2.2]
at net.minecraft.launchwrapper.Launch.main(Launch.java:30) [launchwrapper-of-2.2.jar:2.2]
Caused by: java.lang.NullPointerException
at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:177) ~[launchwrapper-of-2.2.jar:2.2]
... 6 more

[AlphaBs]

I installed Optifine_HD_U_G6_pre1 from official download site but I can't reproduce your error. can you send me .meloncher folder?

[MelonHell]

I found a way to reproduce the problem. the fact is that in v3.3.2, when launching the optifine, the jar from vanilla 1.12.2 was used. In v3.3.3 only works if you copy 1.12.2.jar to \versions\1.12.2-Optifine_HD_U_G6_pre1 and rename to 1.12.2-Optifine_HD_U_G6_pre1.jar

It's not difficult for me to add duplicate version file to the optfine installer, but I would like to avoid duplicate files as in v3.3.2

[AlphaBs]

okay I will update it.

by the way, it should work even if 1.12.2-Optifine_HD_U_G6_pre1.jar is not exists. v3.3.3 will download 1.12.2.jar from mojang server and locate it /versions/1.12.2-Optifine_HD_U_G6_pre1/1.12.2-Optifine_HD_U_G6_pre1.jar

[AlphaBs]

Creating duplicate jar files appears to be the intended behavior of the Optifine team. Even if 1.12.2-Optifine~.jar doesn't exist, it doesn't cause any problems because the library downloads it automatically.