Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approver is not propagated to GitLab merge requests #146

Open
dnesting opened this issue Apr 7, 2022 · 1 comment
Open

Approver is not propagated to GitLab merge requests #146

dnesting opened this issue Apr 7, 2022 · 1 comment
Labels
bug GitLab 🦊 Gitlab-specific issue good first issue help wanted

Comments

@dnesting
Copy link

dnesting commented Apr 7, 2022

When using mp push -a dnesting with an enterprise GitLab, merge requests are created with no assignee, despite having an assignee in mp status output.
@dnesting
Copy link
Author

dnesting commented Apr 7, 2022

I suspect the culprit is at https://github.com/Clever/microplane/blob/master/push/pushGitlab.go#L52. The GitLab merge request options should include an Assignee up front (see https://github.com/xanzy/go-gitlab/blob/master/merge_requests.go#L561), but it looks like only a handful of elements are populated, similar to how GitHub works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GitLab 🦊 Gitlab-specific issue good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakegut @dnesting