Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FlowNet2 models #29

Open
mathmanu opened this issue Feb 13, 2018 · 5 comments
Open

Support for FlowNet2 models #29

mathmanu opened this issue Feb 13, 2018 · 5 comments

Comments

@mathmanu
Copy link

Do you have any thoughts about integrating FlowNet2 into this repository?

FlowNet2 models (including the custom operations such as correlation) have become available for PyTorch 0.3, Python 3.x.
https://github.com/vt-vl-lab/pytorch_flownet2
https://github.com/hellock/flownet2-pytorch

I am asking this is because this repository is structured in a better way and is easier to use and modify.

@ClementPinard
Copy link
Owner

thanks !
I have issued a feature request for correlation module here some time ago : pytorch/pytorch/issues/4073

As for now, I don't have much time to spend on this personal project. If the feature is integrated in future version, I'll make up some time to use it for FlowNetC training
If not, it may take some time, but I'll try to do the PR myself.

I prefer not to have personal modules as in NVIDIA's repo, because as you said the main goal here is to maintain the clearest code possible, which onyl requires to get the latest pytorch release and not build anything

@mathmanu
Copy link
Author

mathmanu commented Feb 13, 2018

Thanks. I did a +1 for your feature request :)

@mathmanu
Copy link
Author

Alternately, the correlation can be implemented with PyTorch code like the CorrelationLayer here:
https://github.com/onlytailei/pytorch-flownet2/blob/master/nets/flownetC.py

Not sure about its speed though.

@ClementPinard
Copy link
Owner

You can have a look a this implementation, I'm planning on using it for a FlowNetC version and then hopefully a full FlowNet2 architecture
https://github.com/ClementPinard/Pytorch-Correlation-extension

@mathmanu
Copy link
Author

Hi, I was wondering about the speedup compared to a pure PyTorch implementation (i.e. without C++/CUDA kernels). Do you have any idea? This is just out of curiosity - but I think it will me a good comparison point in your benchmark table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants