Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT_XXX methods not exported from the main namespace #132

Open
ianhbell opened this issue Dec 16, 2022 · 2 comments
Open

VT_XXX methods not exported from the main namespace #132

ianhbell opened this issue Dec 16, 2022 · 2 comments

Comments

@ianhbell
Copy link
Contributor

When trying to call one of the VT_XXX methods as described in the docs, that doesn't work unless I prefix the function with Clapeyron. The docs suggest all the VT_XX methods are imported to the global namespace (which is a bad idea, in my opinion)

@pw0908
Copy link
Member

pw0908 commented Dec 19, 2022

Hi Ian,

Having VT_XXX not exported was an intentional decision, but I can see it's value, especially if one wants to obtain isochoric properties. We might need to think about a better name for those functions though.

They aren't exported to the global namespace.

@ianhbell
Copy link
Contributor Author

Well, I can see the point, but such a function is VERY useful because it does not invoke any iteration. That implies a significant speed boost if you can use the VT_XXX methods for your problem. At the least the docs need to be more clear about this point, because it is described how the VT_XX methods can be used, but that isn't true.

I would suggest to export them, if it were me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants