Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Notificatio's code to Django instead of JS #1490

Open
JonanOribe opened this issue Jan 27, 2023 · 3 comments
Open

Move Notificatio's code to Django instead of JS #1490

JonanOribe opened this issue Jan 27, 2023 · 3 comments
Assignees
Labels
community help wanted triage Issues that have not been categorized or prioritized

Comments

@JonanOribe
Copy link
Contributor

JonanOribe commented Jan 27, 2023

Idea summary

Looking at project\core\templates\static\js\notifications.js, I saw that the logic behind notification's component is running over JS. Maybe will be better to move this to Django/Python syntax to unify the platform.

Further details

Will be easier to rewrite this code as DJANGO {% if %} {% else%}, that use JS on one side of the project and Python on another

image

I could take this task if necessary

@JonanOribe JonanOribe added community help wanted triage Issues that have not been categorized or prioritized labels Jan 27, 2023
@JonanOribe
Copy link
Contributor Author

JonanOribe commented Jan 30, 2023

@brylie looking at the admin panel, I found that we have two diferent types of notifications. Could be interesting change the name of one of them to avoid misunderstandings

image

One is like a notification like "something happens" (new follower) and the other one is a notification on detail. What you think about this?

@brylie
Copy link
Member

brylie commented Jan 30, 2023

Yeah, we should clarify the difference between those notifications. Can you find the places in the code where both types of notifications are defined?

@Lvcky-gg
Copy link

I can take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community help wanted triage Issues that have not been categorized or prioritized
Projects
None yet
Development

No branches or pull requests

3 participants