Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Following" tab to the user profile view #1447

Closed
4 tasks
Tracked by #1429
brylie opened this issue Oct 21, 2022 · 6 comments · Fixed by #1463 · May be fixed by #1472
Closed
4 tasks
Tracked by #1429

Add "Following" tab to the user profile view #1447

brylie opened this issue Oct 21, 2022 · 6 comments · Fixed by #1463 · May be fixed by #1472

Comments

@brylie
Copy link
Member

brylie commented Oct 21, 2022

We recently removed some features from the user Profile view and now want to reimplement them using only Django.

This task will be to add a "Following" tab to the user profile view. The tab should link to a sub-path of the user profile, so it is clear to the viewer that they are viewing users that a particular user is following.

Task

All of these tasks should be done in the accounts app.

  • create a Django view called UserFollowing (in accounts/views.py)
  • create a URL definition profile/<str:username>/following that renders the UserFollowing view ( in accounts/urls.py)
  • ensure the UserFollowing view context contains a list of users that the relevant user is following (given via the username in the URL)
    • note, it should be possible to get profiles that the user follower via user.profile.following or just profile.following
  • create a template to render the followed usernames - for now, extending base.html so we have consistent branding (in accounts/templates/accounts/user_civis.html)
@wippo-devops
Copy link
Contributor

I would like to work on this.

@belalmn-cmu
Copy link

Regarding the newly created following tab, I noticed that there were no added unit testcases provided in the accounts/views_tests.py

We've created some testcases that are consistent with other provided testcases. I'd like to provide these as a new PR.

Please let me know if this is possible and/or if we need to create a new issue for this implementation.

@brylie
Copy link
Member Author

brylie commented Nov 15, 2022

Sure thing, thanks! Just open the new pull request and link it to this issue.

@brylie brylie reopened this Nov 15, 2022
@Nehemiah60
Copy link
Contributor

Hello @brylie. Is this issue still open? I will love to work on this issue. Thanks.

@Nehemiah60
Copy link
Contributor

Hello, @brylie. I think this issue has been solved already. There is a ProfileFollowing class that renders the users that a specific user is following.

@brylie
Copy link
Member Author

brylie commented Feb 20, 2023

Ok cool beans

@brylie brylie closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment