Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy in our pre-commit settings #1372

Open
brylie opened this issue Oct 4, 2022 · 4 comments
Open

Enable mypy in our pre-commit settings #1372

brylie opened this issue Oct 4, 2022 · 4 comments
Assignees
@Anuj-Kumar-AJ
Labels
community enhancement good first issue hacktoberfest help wanted triage Issues that have not been categorized or prioritized

Comments

@brylie
Copy link
Member

brylie commented Oct 4, 2022 •
edited

Idea summary

Continued from #1331

Further details

Enable mypy in our pre-commit settings by adding mirrors-mypy.
@Anuj-Kumar-AJ
Copy link
Contributor

hi @brylie, I want work for fixing on this issue, can you assign it to me.

@brylie brylie closed this as completed Oct 4, 2022
@brylie brylie reopened this Oct 4, 2022
@brylie
Copy link
Member Author

brylie commented Oct 4, 2022

Hei @Anuj-Kumar-AJ. Let's experiment with mypy-pre commit. We may need to configure Django-stubs, so we get fewer type errors.

@Anuj-Kumar-AJ
Copy link
Contributor

Hi @brylie , sorry for the delay . It was my first PR , anyways
I have send PR for this issue.

c155a35

@brylie brylie mentioned this issue Oct 7, 2022
Closed
@owenwu811
Copy link

  1. pip install pre-commit
  3. pre-commit install
    Optional:
  4. pre-commit run --all-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anuj-Kumar-AJ Anuj-Kumar-AJ

Labels
community enhancement good first issue hacktoberfest help wanted triage Issues that have not been categorized or prioritized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brylie @Anuj-Kumar-AJ @owenwu811