Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle gstreamer in Windows installers to support media out of the box without VLC #223

Open
ousia opened this issue Nov 5, 2021 · 6 comments
Labels

Comments

@ousia
Copy link
Contributor

ousia commented Nov 5, 2021

[This comes from https://github.com//issues/212#issuecomment-961458672.]

The attached PDF document contains a video on the second page that should autostart as the page is entered (and autostop as the page is left).

@Cimbali, reports that video autostart should work fine with latest version (1.7b1). I cannot make it work with these Windows binaries.

The video doesn’t play at all, not even by clicking on it. I guess this might be related to GStreamer and its Python bindings.

@Cimbali Cimbali added the bug label Nov 5, 2021
@Cimbali
Copy link
Owner

Cimbali commented Nov 5, 2021

Do you have VLC on your system, and if so can you try with enabled=on under [vlc] in %APPDATA%\pympress.ini?

If that works the issue is probably limited to packaging the GStreamer dependencies.

@ousia
Copy link
Contributor Author

ousia commented Nov 5, 2021

I don’t have it on the Windows system I use, but I can fake it with a portable installation.

IMHO, packaging the GStreamer dependencies would be great to have a complete solution (and portable too).

@Cimbali
Copy link
Owner

Cimbali commented Nov 5, 2021

The goal is to indeed package the gstreamer dependencies, I’m just trying to confirm that’s the only thing going wrong. If you don’t have VLC don’t worry though I’ll test it at some point.

@ousia
Copy link
Contributor Author

ousia commented Nov 9, 2021

Many thanks for commit d989d63.

I’m afraid I don’t get the video playing (not even clicking on it).

I’m going to check it with the new beta (once it’s available).

@Cimbali
Copy link
Owner

Cimbali commented Nov 14, 2021

The gstreamer backend works with on windows msys for non-frozen packages, but doesn’t seem to survive to the “freezing” (i.e. building the .exe) process. All I get are the following errors:

C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: cannot register existing type 'GWin32RegistryKey'
  Gst.init(gst_opts)
C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: cannot add private field to invalid (non-instantiatable) type '<invalid>'
  Gst.init(gst_opts)
C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: cannot register existing type 'GInitable'
  Gst.init(gst_opts)
C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: g_type_interface_add_prerequisite: assertion 'G_TYPE_IS_INTERFACE (interface_type)' failed
  Gst.init(gst_opts)
C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: g_once_init_leave: assertion 'result != 0' failed
  Gst.init(gst_opts)
C:/msys64\home\me\pympress/pympress/media_overlays/gst_backend.py:181: Warning: g_type_add_interface_static: assertion 'G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
  Gst.init(gst_opts)

For now, media backends on windows will have to be limited to VLC.

@Cimbali
Copy link
Owner

Cimbali commented Nov 15, 2021

I’m repurposing this issue for the gstreamer bundling.

I’ve tested both playing and auto-playing of media, which both work with v1.7.0b3 on Windows provided VLC is installed.

@Cimbali Cimbali changed the title video isn’t played at all (version 1.7b1) Bundle gstreamer in Windows installers to support media out of the box without VLC Nov 15, 2021
smbct pushed a commit to smbct/pympress that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants