Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider versioning scheme #298

Open
mathiasbynens opened this issue Apr 24, 2023 · 0 comments
Open

Reconsider versioning scheme #298

mathiasbynens opened this issue Apr 24, 2023 · 0 comments

Comments

@mathiasbynens
Copy link
Member

mathiasbynens commented Apr 24, 2023

Currently, devtools-protocol is being versioned as 0.0.<revision>, e.g. 0.0.1134390. However, we’re increasingly moving to using Chrome version numbers as the source of truth rather than branch positions / revision numbers.

Can we reconsider versioning devtools-protocol as 1.0.0-<chrome-version>, e.g. 1.0.0-112.0.5615.137? This is valid per semver; it’s interpreted as a pre-release version.

> semver.valid('1.0.0-112.0.5615.137')
'1.0.0-112.0.5615.137'

Motivation: We currently have some extra code to track version numbers alongside revision IDs in both Puppeteer and the Chrome for Testing availability dashboard, for the sole purpose of figuring out which devtools-protocol version to bundle. It would be nice if we could get rid of that.

In addition to this technical reason, I’d argue that Chrome version numbers are more intuitive and recognizable than the arbitrary-looking revision IDs.

cc @OrKoN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant