Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buffer Types #63

Open
ChrisPenner opened this issue Nov 9, 2018 · 1 comment
Open

Add Buffer Types #63

ChrisPenner opened this issue Nov 9, 2018 · 1 comment
Milestone

Comments

@ChrisPenner
Copy link
Owner

ChrisPenner commented Nov 9, 2018

cc @jmatsushita

Allow Buffers to have types by introducing a new event type:

data BufTypeChanged bufType = BufTypeChanged

BufTypeChanged ReadOnlyBuffer for read-only buffers in rasa-ext-files (rasa -R example.txt)
BufTypeChanged (EditorBuffer languageType) for specifying syntax choice in rasa-ext-syntax. Allowing to make syntax modular by having for instance a markdown syntax extension listen to BufferTypeChanged (EditorBuffer MarkdownLanguage)
BufTypeChanged FileBrowser for a file browser, etc.

@ChrisPenner ChrisPenner added this to the TODO milestone Nov 9, 2018
@ChrisPenner
Copy link
Owner Author

@jmatsushita In response to your questions in #2 ,

Should the BufTypeChanged type be introduced in Rasa.Internal.Events or in an extension?
Should BufAdded be extended also to include the BufType in addition to the BufRef?

Yes, I think that makes sense for both of those. The tricky bit will be how to standardize buffer types across all extensions? We can either add some common ones into the core, or we can write a simple module that just has 'all' the filetypes in it and people can add new ones as needed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant