Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-lens: Overly restrictive bounds on Hackage #51

Open
srhb opened this issue Apr 29, 2017 · 6 comments
Open

text-lens: Overly restrictive bounds on Hackage #51

srhb opened this issue Apr 29, 2017 · 6 comments

Comments

@srhb
Copy link

srhb commented Apr 29, 2017

text-lens builds just fine with extra == 1.5.1 and lens == 4.15.1, but is restricted to < 1.5 and ==4.14.* respectively.

This affects package generation for at least Nix (and hence NixOS) as well. Can you bump them? :)

@ChrisPenner
Copy link
Owner

Hey there! Sorry; I'm actually still pretty new to Haskell package development; I don't have any bounds specified in my cabal file; does that mean it's defaulting to something? What would you like me to set the bounds to? Thanks!

@srhb
Copy link
Author

srhb commented Apr 30, 2017

I am unaware of any Hackage defaulting mechanics, so I have no idea where those bounds are coming from. But they are there! Very surprising. The bounds should be specified according to the PVP. In this case specifically we know that it should include at least extra 1.5.*, and assume breakage with the next major version (1.6). That is, the upper bound should be < 1.6 and the lower bound should be the earliest version you know it works with. LIkewise for all the other versions, we know text-lens builds with lens major version 4.15, so its upper bound should be < 4.16 etc.

Thanks! :-)

@srhb
Copy link
Author

srhb commented May 15, 2017

To add to the mystery, here is the cabal file (with bounds specified as above) according to Hackage.

@srhb
Copy link
Author

srhb commented Jul 3, 2017

I'm starting to think that maybe a Hackage trustee added them if there were none to begin with.

@ChrisPenner
Copy link
Owner

Ahh, yeah; that's probably the case. Perhaps @hvr ??

@hvr
Copy link
Contributor

hvr commented Jul 3, 2017

@srhb

I'm starting to think that maybe a Hackage trustee added them if there were none to begin with.

Nope ;-)

If a Trustee or anyone else performs a revision it would show up on Hackage rather explicitly.

@ChrisPenner you may remember #4? :-)

All you need to do is specify an explicit upper bound in your .cabal file, as Stack only adds the bounds that weren't explicitly stated in your .cabal file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants