Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fusion file uploads where IFile is in a list #7094

Merged
merged 3 commits into from May 13, 2024

Conversation

Enterprize1
Copy link
Contributor

Because discovering files in a ListValueNode called .Value on the items the CollectFiles method was called with the wrong type leading the discovery mechanism to not look inside the Nodes contained in a list.

Closes #7093

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.18%. Comparing base (9515881) to head (d4b394e).

Files Patch % Lines
...Abstractions/Serialization/Utf8JsonWriterHelper.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7094      +/-   ##
==========================================
- Coverage   79.75%   79.18%   -0.58%     
==========================================
  Files        2645     2662      +17     
  Lines      132626   133189     +563     
==========================================
- Hits       105781   105468     -313     
- Misses      26845    27721     +876     
Flag Coverage Δ
unittests 79.18% <0.00%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
Copy link
Member

Thanks for contributing ... I will have a look at it.

@michaelstaib michaelstaib merged commit 4cc8cd0 into ChilliCream:main May 13, 2024
11 of 13 checks passed
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fusion does not forward file uploads when they are contained in a list
4 participants