Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotChocolate.Types.FSharp always depends on latest FSharp.Core version? #6901

Open
cmeeren opened this issue Feb 15, 2024 · 0 comments · May be fixed by #6902
Open

HotChocolate.Types.FSharp always depends on latest FSharp.Core version? #6901

cmeeren opened this issue Feb 15, 2024 · 0 comments · May be fixed by #6902
Labels

Comments

@cmeeren
Copy link
Contributor

cmeeren commented Feb 15, 2024

Product

Hot Chocolate

Version

14.0.0-p.35

Link to minimal reproduction

None

Steps to reproduce

It seems like HotChocolate.Types.FSharp always depends on the latest FSharp.Core version at the time of release. This is unnecessarily restrictive. It is safe to pin a specific FSharp.Core version, e.g. 8.0.100 which is the first stable 8.x version. (AFAIK there is also no need to have an upper bound, as FSharp.Core is generally binary compatible. I've never had any problems targeting versions as low as 4.x in my NuGet packages.)

What is expected?

See above.

What is actually happening?

See above.

Relevant log output

No response

Additional context

No response

@cmeeren cmeeren added the 🐛 bug Something isn't working label Feb 15, 2024
@cmeeren cmeeren linked a pull request Feb 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants