Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle visibility of tabs hotkey behaves differently than right click when used with Show live tabs only #5341

Open
4 tasks done
bontalor opened this issue Apr 21, 2024 · 3 comments · May be fixed by #5353
Open
4 tasks done

Toggle visibility of tabs hotkey behaves differently than right click when used with Show live tabs only #5341

bontalor opened this issue Apr 21, 2024 · 3 comments · May be fixed by #5353
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@bontalor
Copy link

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When using Show live tabs only, using right click to toggle visibility of tabs will toggle back to only showing live channels, but when using the Ctrl+U hotkey it toggles back to showing all tabs regardless of live or not.

Screenshots

right click example:

right.click.example.mp4

hotkey example:

hotkey.example.mp4

OS and Chatterino Version

Chatterino Nightly 2.5.0 (commit 3aead09) built on 2024-04-21 with Qt 6.5.0, MSVC 193833135 Running on Windows 11 Version 23H2, kernel: 10.0.22631
@bontalor bontalor added the issue-report An issue reported by a user. label Apr 21, 2024
@Nerixyz
Copy link
Contributor

Nerixyz commented Apr 21, 2024

I'd say this is a bug with the CTRL+U hotkey, as it will always show all tabs:

chatterino2/src/widgets/Window.cpp

Lines 648 to 653 in 3aead09

else if (arg == "toggle")
{
this->notebook_->setShowTabs(!this->notebook_->getShowTabs());
getSettings()->tabVisibility.setValue(
NotebookTabVisibility::AllTabs);
}

The menu action is identical to pressing CTRL+Shift+L (toggle live tabs only).

@gerbsec

This comment was marked as outdated.

Sign in to view
@Felanbird

This comment was marked as outdated.

Sign in to view
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Apr 22, 2024
@Nerixyz Nerixyz linked a pull request Apr 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(notebook): align actions and hotkeys Nerixyz/chatterino2
5 participants
@pajlada @Nerixyz @Felanbird @bontalor @gerbsec