Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean property table properties #613

Open
lilleyse opened this issue Jan 9, 2024 · 0 comments
Open

Add support for boolean property table properties #613

lilleyse opened this issue Jan 9, 2024 · 0 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Jan 9, 2024

We didn't add support for boolean properties in #573. It would look something like this:

  • Allow boolean properties in MetadataUtil
  • Add BOOLEAN to DataType, MdlInternalPropertyType, and MdlExternalPropertyType. Update template specializations in DataTypeUtil and anything else that switches based on DataType
  • Add cesium_property_bool and cesium_internal_property_table_bool_lookup to cesium.mdl. cesium_property_bool can be modeled after cesium_property_int, cesium_internal_property_table_bool_lookup can be modelled after cesium_internal_property_table_int_lookup (but without has_no_data, no_data, and default_value, which aren't relevant for boolean properties).
  • Update FabricMaterial
  • Add cesium_property_bool to FabricUtil::isCesiumPropertyNode

I'm probably forgetting some areas, but this should be a good start.

Sample tileset: 3d-tiles-samples-boolean-in-property-table 2024-01-09.zip (same testing procedure as #614)

@lilleyse lilleyse changed the title Add support for boolean metadata properties Add support for boolean property table properties Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants