Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponseStreamReader does not handle chunked encoding #217

Open
markpatton opened this issue May 1, 2017 · 2 comments
Open

ResponseStreamReader does not handle chunked encoding #217

markpatton opened this issue May 1, 2017 · 2 comments

Comments

@markpatton
Copy link

We've had an issue with Water Butler being unable to read streams with chunked encoding.

If you look at the constructor of ResponseStreamReader(BaseStream) in waterbutler/core/streams/http.py you will see that if size is None and unsizable is False, the attempt to turn size into an int will fail. This seems to happen with chunked encoding. As a workaround for our testing, we just set self._size to None in that circumstance.

@felliott
Copy link
Member

felliott commented May 9, 2017

Thanks, @markpatton!

That unsizable flag seems to be some leftover code from a long time ago. The only place where I could find it being used was here, and that code doesn't do that anymore. I'm not sure what the correct behavior is here yet, but I'll look into it.

Cheers,
@felliott

@felliott
Copy link
Member

Update: this should be fixed in the next release of WaterButler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants