Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep the codebase for components out-of-spec to the C++20 WP #41

Open
CaseyCarter opened this issue Oct 26, 2016 · 4 comments
Open

Sweep the codebase for components out-of-spec to the C++20 WP #41

CaseyCarter opened this issue Oct 26, 2016 · 4 comments

Comments

@CaseyCarter
Copy link
Owner

Anything not integrated by now is likely not important enough to be integrated.

@ericniebler
Copy link
Collaborator

Yes please. I'm particular, I'm blocked by the not-too-spec way you define value_type.

@CaseyCarter
Copy link
Owner Author

I'm particular, I'm blocked by the not-too-spec way you define value_type.

Fixed in bb16557.

@CaseyCarter CaseyCarter changed the title Sweep the codebase for components out-of-spec to D0459R1 Sweep the codebase for components out-of-spec to the Ranges TS WP Feb 5, 2017
@cjdb
Copy link
Collaborator

cjdb commented Feb 22, 2017

Should functions like find_if_not retain their __f wrapper?

template <class I, class S, class Pred, class Proj = identity> // need to swap Pred and Proj
requires
	InputIterator<__f<I>>() &&
	Sentinel<__f<S>, __f<I>>() &&
	IndirectPredicate<Pred, projected<__f<I>, Proj>>()
__f<I> find_if_not(I&& first, S&& last, Pred pred, Proj proj = Proj{})
{
	return __stl2::find_if(__stl2::forward<I>(first), __stl2::forward<S>(last),
		__stl2::not_fn(__stl2::ref(pred)), __stl2::ref(proj));
}

find_if_not in N4622 doesn't mention decay_t, but I can't project what will happen if it's removed.

@CaseyCarter
Copy link
Owner Author

It should be safe to unwrap those and take the function arguments by value. Any resulting ambiguities are extensions that I need to move to namespace ext.

@cjdb cjdb changed the title Sweep the codebase for components out-of-spec to the Ranges TS WP Sweep the codebase for components out-of-spec to the C++20 WP Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants