Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "exports" section to package.json #254

Open
brandoncharnesky opened this issue May 6, 2024 · 0 comments
Open

Add "exports" section to package.json #254

brandoncharnesky opened this issue May 6, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@brandoncharnesky
Copy link
Contributor

Add an "exports" section to the package.json to define the cjs/esm versions (https://nodejs.org/api/packages.html#conditional-exports). Some downstream tools (vitest: https://github.com./vitest-dev/vitest/discussions/4233) fail to recognize the current method we are using (defining "module" in the package.json file).

Unclear if there would be other downstream effects from adding in this "exports" section.

@brandoncharnesky brandoncharnesky added the help wanted Extra attention is needed label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant