Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using engine/internal for domain entities #7

Open
zboralski opened this issue Apr 27, 2018 · 2 comments
Open

using engine/internal for domain entities #7

zboralski opened this issue Apr 27, 2018 · 2 comments

Comments

@zboralski
Copy link

Wouldn't it make sense to move the domain package to engine/internal?

When the go command sees an import of a package with internal in its path, it verifies that the package doing the import is within the tree rooted at the parent of the internal directory.

@CaptainCodeman
Copy link
Owner

Possibly, although in real apps I often have other services that make use of the same domain structs so it's useful being able to pull them in to those.

@CaptainCodeman
Copy link
Owner

"services" being an AppEngine / GCP thing - really separate apps in another codebase that need to work with the same data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants