Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions don't work if iCloudDrive is disabled. #39

Open
PPacie opened this issue May 18, 2017 · 2 comments
Open

Reactions don't work if iCloudDrive is disabled. #39

PPacie opened this issue May 18, 2017 · 2 comments
Labels

Comments

@PPacie
Copy link

PPacie commented May 18, 2017

Basically, CloudKit doesn't return the fetchUserRecordID if iCloudDrive is disabled in Settings even if the user is logged into iCloud.

I am not sure weather this is the way it should work or if it's an issue. Just in case I've opened a rdar 32277653 .

Apple documentation is kind of confusing as they encourage to enable iCloudDrive but they don't specify that it is a requirement. However, from a logical point of view, this shouldn't be a requirement to get the iCloud UserRecordID unless you would need to make use of the disk space of iCloudDrive (e.g: save documents to iCloudDrive, etc).

@PPacie PPacie changed the title Reactions doesn't work if iCloudDrive is disabled. Reactions don't work if iCloudDrive is disabled. May 18, 2017
@betzerra betzerra added the bug label May 18, 2017
@betzerra
Copy link
Member

@PPacie great finding, thanks!

For now, all I'm going to do is the following:

  • show a modal explaining that you need to be logged in at iCloud (and having iCloudDrive enabled).
  • add tracking when the modal is shown.

After shipping, I'll measure the number of people that can't use reactions because of this. If the number is significant I'll add the option of logging with twitter.

@PPacie
Copy link
Author

PPacie commented May 19, 2017

Yeah, I think another alternative would be to cache a local timestamp token so you avoid bothering the user with login/pass.

Only downside of local cached token would be the case where the user uninstall and re-install the app. The user wouldn't be able to recover past reactions.

On the other hand, an Apple CloudKit engineer told me that that's the way it's intended to work (iCloudDrive should be enabled for CK to work) but that the documentation isn't clear. I suggested that it would be way much useful to be able to get the iCloudID even if iCloudDrive is disabled. Let's see what happens. Keep you updated.

@betzerra betzerra added this to the 1.0.0 milestone May 21, 2017
@betzerra betzerra modified the milestones: 1.1.0, 1.0.0 Jun 7, 2017
@betzerra betzerra modified the milestones: 1.1.0, 1.2.0 Oct 24, 2017
@betzerra betzerra removed this from the 1.2.0 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants