Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test to track main function number #929

Open
IlmariReissumies opened this issue Feb 22, 2023 · 0 comments
Open

Add regression test to track main function number #929

IlmariReissumies opened this issue Feb 22, 2023 · 0 comments

Comments

@IlmariReissumies
Copy link
Member

The compiler assumes that the main function is the first function after the various stubs introduced in data_to_word; at the time of writing, this is function 62. This number isn't specified anywhere, but is rather calculated.

The Pancake compiler needs to somehow know what this number is going to be, which is currently done by hard-coding it in crep_to_loop as follows

Definition first_name_def:
  first_name = 62:num
End

I think this hardcoding is not terrible: the alternative would be to have the pancake compiler depend on data_to_word. But it does create hard-to-trace errors whenever stubs are added or removed, causing the number to be out of synch. The end-to-end proofs for Pancake, once they exist, should break when this happens. But until they do, it would be nice to have some way of keeping them synched.

This issue is to create a regression test which fails if the number of stubs and first_name fails to line up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant