Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered translucent blocks do not render correctly #38

Closed
RdSt14 opened this issue Jun 28, 2020 · 28 comments · Fixed by stormdirus2/sodium-fabric#3, Kubasor/sodium-fabric#1 or #2016
Closed
Labels
R-pending-release Resolution: Pending release S-confirmed Status: Confirmed S-nyi Status: Not yet implemented T-bug Type: Bug
Milestone

Comments

@RdSt14
Copy link

RdSt14 commented Jun 28, 2020

Expected Behavior

Water will be visible inside glass stained pipes, commonly used in water elevators

Actual Behavior

Water is not visible through stained glasses, although items can be seen flowing

Reproduction Steps

Make a water tube, doesn't matter if its flowing or a water elevator type.

Attachments

https://cdn.discordapp.com/attachments/389371678859460611/726798724206166066/received_707934516451025.png

System Information

  • Java Version: [Java 8 Update 251]
  • CPU: [Intel Core i5-7200U]
  • GPU: [Intel HD Graphics 620]
@RdSt14 RdSt14 added the T-bug Type: Bug label Jun 28, 2020
@jellysquid3 jellysquid3 added the S-nyi Status: Not yet implemented label Jun 28, 2020
@jellysquid3 jellysquid3 added this to the Release 0.2 milestone Jul 8, 2020
@jellysquid3 jellysquid3 pinned this issue Jul 8, 2020
@Xephobia
Copy link

Xephobia commented Jul 9, 2020

also it show other weird thing like the sky rendering black instead of white or stained glass can't show other stained glasses behind them

@jellysquid3 jellysquid3 changed the title Stained glasses don't provide transparent view for water Tracking issue for Translucent Quad Sorting Jul 14, 2020
@jellysquid3
Copy link
Member

Sodium does not implement quad sorting for translucent block faces, leading to all kinds of translucency issues. I'll be making this a tracking issue for other problems caused by it.

@jellysquid3 jellysquid3 changed the title Tracking issue for Translucent Quad Sorting Block translucency effects are broken Jul 14, 2020
@muzikbike
Copy link

Can confirm all kinds of weird behaviour with translucent blocks.
2020-07-15_20 38 01
2020-07-15_20 40 25

You can even see chunk borders in ice:
2020-07-15_20 44 41
2020-07-15_20 44 46

@catgirldoll
Copy link

More images of the issue

no rendering issue when water rendering isn't effecting the block
2020-07-17_18 25 40

Only top texture on the block renders through water
2020-07-17_18 08 09

As a result of the issue above, you cannot see certain transparent blocks above you while inside of water
2020-07-17_18 12 42

Issue applies to flowing water as well
2020-07-17_18 14 41

@KrisCris
Copy link

Also, portals are invisible behind glass.

@James103
Copy link

See this video by Xisumavoid for another example of this issue with Honey Blocks (they are almost as see-through as glass, even though they shouldn't be that translucent).

With Sodium:
image

Without Sodium:
image

@zLauch
Copy link

zLauch commented Aug 28, 2020

Nether Portals also not showing up
2020-08-28_20 09 29
2020-08-28_20 10 56

@lordofpipes
Copy link

Just in case this is useful, not sure if I'm rehashing what's already known -

I'm getting same rendering as @zLauch on f577eb2 (and also on ishland's 1.16.2 support PR, though evidently that's not the actual cause) but not 0.1.0. Hardware is AMD Mullins, happens with all of sodium's rendering modes.

Java is version 1.8.0_262, using 64-bit architecture.

AMD A8-7410 APU with AMD Radeon R5 Graphics
Advanced Micro Devices, Inc. [AMD/ATI] Mullins [Radeon R4/R5 Graphics] (rev 45)

Subsystem: Dell Device 06bf

Kernel driver in use: amdgpu

OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.1.6

@Hnaguski
Copy link

Not sure if this is helpful/already known but it seems like on chunk borders translucency effects are less broken? I've only tested it with honey/slime blocks but it seems like when you have two blocks on either side of a chunk border the middle part gets rendered correctly. The image should be a bit better at explaining.
2020-09-27_20 20 38

@goobyq
Copy link

goobyq commented Mar 23, 2022

image

image image

Water in a water column renders with strips and breaks off directly on the borders it seems like. This changes while you move through the column where you can see random vertical and horizontal "panes" of darker water.
java_oz3Hll8vpO
Not sure if it's been referenced elsewhere but on subchunks it adds slices/faces to water

@Yadokingu
Copy link

I have the same problem with glass not rendering through water.
2022-04-16_11 53 30
2022-04-16_11 54 47

@RedstoneManiac3Xbox
Copy link

is there an actual implementable fix for this yet? or am I gonna be stuck not viewing the waterfalls in my terrarium?

@catgirldoll
Copy link

is there an actual implementable fix for this yet? or am I gonna be stuck not viewing the waterfalls in my terrarium?

No, it's a WIP. See: pull request

@FreezePhoenix
Copy link

FreezePhoenix commented Jul 19, 2022

Don't know if anyone has noticed - but this only affects things that are placed in Translucent render layers. This includes water, tinted glass, stained glass, honey, slime, etc. It would appear that faces are simply sorted by some insertion order.
2022-07-19_14 28 24
2022-07-19_14 28 07
2022-07-19_14 28 17

@JaehaerysWise
Copy link

Posted another issue about water rendering issue in stained glass, but I feel like I should add it here as well
First pic (with continuity). Second pic (without continuity)
2022-07-20_19 11 51
2022-07-20_19 31 40

@silversquirl
Copy link
Member

Please stop!

...adding yet more images of the same thing

This bug is being actively worked on, and we don't need any more information about it.
Instead, sit down, relax, and wait patiently.

Thanks!

@CaffeineMC CaffeineMC locked as spam and limited conversation to collaborators Jul 22, 2022
@jellysquid3 jellysquid3 unpinned this issue Oct 29, 2022
@jellysquid3 jellysquid3 pinned this issue Aug 27, 2023
@jellysquid3 jellysquid3 changed the title Block translucency effects are broken Layered translucent blocks do not render correctly Aug 27, 2023
@jellysquid3
Copy link
Member

This problem will be resolved in Sodium 0.6 with the introduction of #2016.

@jellysquid3 jellysquid3 added this to the Sodium 0.6 milestone Feb 4, 2024
jellysquid3 pushed a commit that referenced this issue Feb 15, 2024
This PR implements efficient CPU translucency sorting. See #2016 for a useful overview of the concepts.
Closes #38
@jellysquid3 jellysquid3 added the R-pending-release Resolution: Pending release label Feb 15, 2024
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this issue Apr 6, 2024
…feineMC#2016)

This PR implements efficient CPU translucency sorting. See CaffeineMC#2016 for a useful overview of the concepts.
Closes CaffeineMC#38
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this issue Apr 6, 2024
…feineMC#2016)

This PR implements efficient CPU translucency sorting. See CaffeineMC#2016 for a useful overview of the concepts.
Closes CaffeineMC#38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.