Don't hide the skybox in Spectator mode when inside water, lava or powder snow

[muzikbike]

Request Description

Sodium hides the sky and sun/moon if the camera is subject to water, lava or powder snow fog as a fix for https://bugs.mojang.com/browse/MC-152504. However, Spectator mode isn't intended to be "obscured" by things as the other game modes are - for example, you can see through blocks when inside them unlike in Creative/Survival, and fog distance is considerably increased when inside water or lava compared to other game modes. It would probably make sense to only have this hiding fix apply to creative/survival/adventure modes.

The best fix for this would probably be to disable water, lava and powder snow fog entirely in Spectator mode - that way, there'd be no obstructions at all and you'd be able to see the sky as though you were in any other block.

[douira]

Wouldn't disabling fog make it looks significantly different?

[muzikbike]

Yes, but since the point of Spectator mode is to not have visual hindrances such as the suffocation overlay or on-fire effect displayed on screen I doubt this would actually matter.

[douira]

Vanilla's spectator also doesn't remove fog

[muzikbike]

True. I'm not picky on how this is fixed, if it's decided it should even be fixed at all.

[jellysquid3]

The entire reason this patch exists is to deal with the way that fog interacts with the skybox. Since Minecraft doesn't fully remove the fog, even in spectator mode, it doesn't make sense to change the behavior as you've requested.