Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect mapping of fluid side textures #2471

Open
muzikbike opened this issue May 5, 2024 · 0 comments
Open

Fix incorrect mapping of fluid side textures #2471

muzikbike opened this issue May 5, 2024 · 0 comments
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link

Request Description

The side textures for fluids are not mapped correctly in vanilla or Sodium:

Since fluids don't use proper json models even ten years later, this cannot be fixed via resource packs, and requires code changes. Since there are other issues with vanilla fluid rendering that I have reported and am still to report, I figured this report would fit nicely among them.

This issue is quite hard to see with vanilla's water and lava textures, so I'd recommend using the resource pack attached to MC-267861 to see the issue in action.
2024-05-05_21 04 46
2024-05-05_21 04 49

Note: when fixing the flipped textures issue, the interior of the fluid should be made to render horizontally flipped instead. This is to ensure that every pixel on the outside corresponds to the same pixel on the inside, as is the case for blocks such as powder snow, and in 1.20.3+, spawners and trial spawners.

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement
Development

No branches or pull requests

1 participant