Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow particles to have translucent textures like they previously could #2444

Closed
muzikbike opened this issue May 2, 2024 · 1 comment
Closed
Labels
E-will-not-fix Closed: Will not fix T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link

Request Description

Up until 1.13, particles in the particles.png texture file would render any translucent pixels as actually translucent in-game. When 1.14 split particles into individual texture files, any translucent pixels were either rendered at full opacity or invisible (https://bugs.mojang.com/browse/MC-144009), which persists into the present day. I assume there's some underlying rendering bug that causes this issue. Fixing it probably wouldn't cause any performance deficits (the game already handles translucent particles for stuff like campfires anyway), especially since particles for translucent blocks were themselves incorrectly rendered opaque until that was fixed in around 1.15-1.16 or so.

These bubbles render all translucent pixels within as fully opaque, for example:
2024-05-01_23 47 55
2024-05-01_23 53 48
2024-05-01_23 54 13
2024-05-01_23 54 28
all translucent pixels within as fully opaque, for example:

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels May 2, 2024
@pajicadvance pajicadvance added A-vanilla-issue Area: Vanilla issue and removed S-needs-triage Status: Needs triage labels May 2, 2024
@jellysquid3
Copy link
Member

jellysquid3 commented May 12, 2024

Yes. This is intentional. Particles are only rendered with binary-alpha for performance reasons, since it doesn't need additional framebuffer reads on a rendering task that is historically bound on the fragment shader. Each particle type is rendered in a separate pass, so only particle types which need actual alpha-blending will use it.

@jellysquid3 jellysquid3 closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@jellysquid3 jellysquid3 added E-will-not-fix Closed: Will not fix and removed A-vanilla-issue Area: Vanilla issue labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-will-not-fix Closed: Will not fix T-enhancement Type: Enhancement
Development

No branches or pull requests

3 participants