Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more complete testing to the spanner extract test suite #104

Open
BryanCutler opened this issue Sep 1, 2020 · 0 comments
Open

Add more complete testing to the spanner extract test suite #104

BryanCutler opened this issue Sep 1, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BryanCutler
Copy link
Member

Currently only a simple test case exists. As per comments at #83 (comment), more tests need to be added to exercise the function completely.

Fred's comments on text_extract_dict:

I'd recommend that you remove the last three lines of the current file and replace "file_text" below with a string that exercises the major cases of dictionary extraction:

  • Match at beginning of string, end of string, or in the middle of the string
  • One-token match and multi-token match
  • Non-match that shares the first token (and only the first token) with a two-token dictionary entry
  • Two overlapping matches

You'll also want to exercise case-insensitivity of the dictionary matching.

I think the location of this file is an anachronism. Would you mind moving it to test_data/spanner?

comments on test_extract_regex_tok:

As with the dictionary test, it would be useful to have a target string that contains the main types of regex match -- matches at the beginning, middle, or end of the string; partial matches; substrings that would be matches except they don't start or end on a token boundary.

@BryanCutler BryanCutler added enhancement New feature or request good first issue Good for newcomers labels Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant